Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid formula for computing arrival time and arrival speed when approaching a minor link (trac #1533) #1533

Closed
behrisch opened this issue Jan 5, 2015 · 4 comments

Comments

@behrisch
Copy link
Contributor

commented Jan 5, 2015

  • the formula is wrong when the vehicle has insufficient time to decelerate (causing #1531)
  • arrivalTime is off by one simStep since it does not take into account the movement of the current time step (computation is done before movement takes place)
  • the formula miscalculates the ''time spent at full speed'' anyway
  • invalid distance
  • invalid speed
  • (even ignoring discretization errors)

Migrated from http://sumo.dlr.de/ticket/1533

{
    "status": "closed", 
    "changetime": "2015-01-07T16:06:03Z", 
    "description": "* the formula is wrong when the vehicle has insufficient time to decelerate (causing #1531)\n* arrivalTime is off by one simStep since it does not take into account the movement of the current time step (computation is done before movement takes place)\n* the formula miscalculates the ''time spent at full speed'' anyway \n * invalid distance\n * invalid speed\n * (even ignoring discretization errors)\n\n\n \n \n\n", 
    "reporter": "namdre", 
    "cc": "", 
    "resolution": "fixed", 
    "_ts": "1420646763132637", 
    "component": "microsim - junctions", 
    "summary": "invalid formula for computing arrival time and arrival speed when approaching a minor link", 
    "priority": "major", 
    "keywords": "", 
    "time": "2015-01-05T22:13:59Z", 
    "milestone": "0.23.0", 
    "owner": "namdre", 
    "type": "defect"
}
@behrisch

This comment has been minimized.

Copy link
Contributor Author

commented Jan 5, 2015

@namdre changed description from:

  • the formula is wrong when the vehicle has insufficient time to decelerate (causing #1531)
  • the formula miscalculates the ''time spent at full speed'' anyway
  • invalid distance
  • invalid speed
  • (even ignoring discretization errors)

to:

  • the formula is wrong when the vehicle has insufficient time to decelerate (causing #1531)
  • arrivalTime is off by one simStep since it does not take into account the movement of the current time step (computation is done before movement takes place)
  • the formula miscalculates the ''time spent at full speed'' anyway
  • invalid distance
  • invalid speed
  • (even ignoring discretization errors)
@behrisch

This comment has been minimized.

Copy link
Contributor Author

commented Jan 5, 2015

@namdre committed af16b86 (aka r17556):
added test refs #1533

@behrisch

This comment has been minimized.

Copy link
Contributor Author

commented Jan 5, 2015

@namdre committed 10389b8 (aka r17559):
added test refs #1533

@behrisch

This comment has been minimized.

Copy link
Contributor Author

commented Jan 5, 2015

@behrisch behrisch added this to the 0.23.0 milestone Oct 28, 2017
@behrisch behrisch closed this Oct 28, 2017
@behrisch behrisch added the bug label Oct 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.