Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

visualize custom edge geometry endpoints #3716

Closed
namdre opened this issue Dec 15, 2017 · 2 comments

Comments

@namdre
Copy link
Contributor

commented Dec 15, 2017

  • should be in a distinct color from junctions and geometry points
  • allow manipulating them with move / delete

most of the code for regular geometry points should be usuable. The only distinctions are:

  • coloring
  • inner vs full geometry: by default only geometry points of the inner geometry are shown (endpoints excluded), when setting geometry points the results are (currently) only applied to the inner geometry. Endpoints must be recognized and treated differently
@palvarezlopez

This comment has been minimized.

Copy link
Contributor

commented Dec 15, 2017

We have two possibilities for moving EndPoints: Either only move the last point, or moving the entire shape (see image). What do you think that it's better?

endpoints

@namdre namdre changed the title visualize custom geometry endpoints visualize custom edge geometry endpoints Dec 15, 2017

@namdre

This comment has been minimized.

Copy link
Contributor Author

commented Dec 15, 2017

Only the endpoint itself should move. The effect should be exactly the same as setting a new value for the virtual edge attribute shapeStart or shapeEnd (i'm only talking about edges here)

@palvarezlopez palvarezlopez added this to the 1.0.0 milestone Feb 2, 2018

@palvarezlopez palvarezlopez self-assigned this Feb 6, 2018

palvarezlopez added a commit that referenced this issue Mar 1, 2018
palvarezlopez added a commit that referenced this issue Mar 2, 2018
palvarezlopez added a commit that referenced this issue Mar 2, 2018
palvarezlopez added a commit that referenced this issue Mar 2, 2018
palvarezlopez added a commit that referenced this issue Mar 8, 2018
palvarezlopez added a commit that referenced this issue Mar 9, 2018
palvarezlopez added a commit that referenced this issue Mar 9, 2018
palvarezlopez added a commit that referenced this issue Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.