Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad default values for electricity consumption model parameters #5505

Closed
namdre opened this issue Apr 23, 2019 · 1 comment

Comments

@namdre
Copy link
Contributor

commented Apr 23, 2019

In particular the rollDragCoefficient is far too high.

@namdre namdre closed this in ca90c74 Apr 23, 2019

namdre added a commit that referenced this issue Apr 23, 2019
@namdre

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

The new default values come from a publication by the model implementers (https://link.springer.com/chapter/10.1007/978-3-662-45079-6_3). The old invalid default values went unnoticed because most of our tests overwrite the defaults.

namdre added a commit that referenced this issue Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.