Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let vehicles collect accumulated waiting time over the last n seconds (trac #999) #999

Closed
behrisch opened this issue Aug 20, 2013 · 8 comments

Comments

@behrisch
Copy link
Contributor

commented Aug 20, 2013

Right now vehicles "forget" about their waiting time as soon as they move even a tiny bit with a speed above 0.1 m/s.

To implement this, a run-length encoding of intervals spent stopped and moving seems useful.

Cumulated waiting time should be accessible

  • via TraCI
  • as vehicle coloring mode in the gui
  • as vehicle property in the gui

Migrated from http://sumo.dlr.de/ticket/999

{
    "status": "closed", 
    "changetime": "2017-05-23T06:12:18Z", 
    "description": "Right now vehicles \"forget\" about their waiting time as soon as they move even a tiny bit with a speed above 0.1 m/s. \n\nTo implement this, a run-length encoding of intervals spent stopped and moving seems useful. \n\nCumulated waiting time should be accessible \n * via TraCI\n * ~~as vehicle coloring mode in the gui~~\n * ~~as vehicle property in the gui~~", 
    "reporter": "namdre", 
    "cc": "", 
    "resolution": "fixed", 
    "_ts": "1495519938280278", 
    "component": "simulation general (micro)", 
    "summary": "let vehicles collect accumulated waiting time over the last n seconds", 
    "priority": "major", 
    "keywords": "", 
    "time": "2013-08-20T12:01:50Z", 
    "milestone": "1.1.0", 
    "owner": "luecken", 
    "type": "enhancement"
}
@behrisch

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2013

@namdre changed component from "other (also unclassified)" to "simulation general (micro)"

@behrisch

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2013

@behrisch changed milestone from "" to "1.1.0"

@behrisch

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2013

Implemented accumulating waiting time, coloring option and vehicle property window listing entry in r20308. Still open is TraCI support, which I didn't figure out.

Also open: copying the code to the pedestrian case (is this required?).

to:

1459106755000464

Implemented accumulating waiting time, coloring option and vehicle property window listing entry in r20308. Still open is TraCI support and command line option, which I didn't figure out, yet.

Also open: copying the code to the pedestrian case (is this required?).

to:

1459108434041522

Implemented accumulating waiting time, coloring option and vehicle property window listing entry in r20308. Still open is TraCI support and command line option, which I didn't figure out, yet.

There is a comment in MSVehicle::planMoveInternal(), that says:
// ... here the vehicle needs to stop close to the stop line
// to ensure it gets onto the junction in the next step. Otherwise the vehicle would 'forget'
// that it already stopped and need to stop again. This is necessary pending implementation of #999

Also open: copying the code to the pedestrian case (is this required?).

And I imagine, that the vehicle's "impatience" could be improved by using the accumulated waiting time (though some formula might be appropriate, where waiting episodes are weighted according to their distance in the past...)

@behrisch

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2013

@namdre committed 7ca38d5 (aka r20435):
visualizing absolute accumulated waiting time rather than percentages. refs #999, refs #36

@behrisch

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2013

In [changeset:"20473"]:
{{{
#!CommitTicketReference repository="" revision="20473"
Merged revision(s) 20332-20472 from trunk/sumo:
updated call to typemap.h generator, refs #3, #1853
........
fixing svn props, refs #22
........
removed outdated comment refs #12
........
fixing potential gui crash
........
whitespace refs #12
........
now showing waitingTime accumulation window in gui refs #36
........
refactoring transportable devices, refs #12
........
post refactoring cleanup, fixing positions in FCD output with GUI, refs #12, #21
........
fixing deviation between person and vehicle position, refs #21
........
adding test for circular net, refs #1032
........
only notifying about entry if the lane reminder is for the entered lane (did not work for circular nets), fix #1032
........
fix #2189
........
adding failing test, refs #1452, #21
........
fixing move reminders with teleports, fix #1452
........
added test refs #1893
........
fix #1893
........
added test refs #2225
........
partial netdiff support for handling roundabouts (only creation)
........
adapting runner for new emission test cycles, refs #21
........
using the new model files, refs #2206
........
updating svn ignore
........
added test for #1351
........
deprecated swap option refs #2116
........
fixing electricity calculation, refs #2206
........
added test fix #1968
........
fixing defaults and units, refs #2211
........
new phemlight version from Graz
........
documenting changes, refs #2206
........
added assertion refs #12
........
fix #2227
........
fix #2226
........
reintegrating urmo
........
persons are visible again. (regression from [20340])
........
fix #1852
........
fix #2192
........
fixing some delete issues which were introduced by the urmo merge
........
fix #2056
........
patching expected results refs #21, refs #2056
........
another merge leftover
........
better with units, refs #2
........
adapting to correct model, refs #21, #2206
........
fix #2133
........
adapting to units in help string, refs #21
........
removing unused element from test input, refs #21
........
added test refs #2230
........
adapting schemata for output files, refs #2
........
adapting to modified error messages, refs #21
........
adapting to movereminder teleport fix, refs #21
........
added test refs #1980
........
fix #1980
........
need to check embeddedness before connecting
........
fixed bug where junctions with uncommon shapes could not be selected refs #457
........
adapting meso tests to electricity, refs #21
........
fixing svn props, refs #22
........
fixing plugin extraction, refs #2168
........
fixing unused parameter warnings, refs #3
........
adapting personTrip schema, refs #2
........
adapting to new personTrips, refs #21
........
fixing vtype output for jtrrouter, refs #21
........
documenting external code at http://sumo.dlr.de/wiki/License, fix #2134
........
added license reference, refs #2134
........
removing txt file from Makefile, refs #3
........
adapting test resulte, refs #21
........
happy new year, refs #22
........
visualizing absolute accumulated waiting time rather than percentages. refs #999, refs #36
........
meso is no longer a separate binary
........
fixed vehicle coloring regression
........
fixed regression that was causing gui-freeze due to invalid mutex retention
........
happy new year leftover, refs #22
........
fixed several memory leaks exposed by sanity checks with clang++-3.6, refs #12
........
added test refs #2244
........
added failing test refs #2246
........
re-adding eclipse-project settings (deleted by mistake in r20447)
........
relocating test case, patching expected results refs #2246
........
fix #2246
........
trimming line for platform independence, refs #21, #22
........
improving efficiency (amends [20452]) refs #12
........
sane line endings for phemlight, refs #22
........
}}}

to:

1473141616500039

removed clutter

@behrisch

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2013

only traci access is still lacking

  • @namdre changed description from:

Right now vehicles "forget" about their waiting time as soon as they move even a tiny bit with a speed above 0.1 m/s.

To implement this, a run-length encoding of intervals spent stopped and moving seems useful.

Cumulated waiting time should be accessible

  • via TraCI
  • as vehicle coloring mode in the gui
  • as vehicle property in the gui

to:

Right now vehicles "forget" about their waiting time as soon as they move even a tiny bit with a speed above 0.1 m/s.

To implement this, a run-length encoding of intervals spent stopped and moving seems useful.

Cumulated waiting time should be accessible

  • via TraCI
  • as vehicle coloring mode in the gui
  • as vehicle property in the gui
@behrisch

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2013

@behrisch

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2013

@leoluecken committed 9c44c5f (aka r24426):
Adding / Integrating getAccumulatedWaitingTime() TraCI-tests (for cpp-testClient test failed before, so results are not approved), refs #999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.