Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traci.person.replaceStage(personId, stageIndex, traciStage) #5797

Merged
merged 1 commit into from Jul 3, 2019

Conversation

@tkchouaki
Copy link
Contributor

commented Jul 3, 2019

Hi,
i added the ability to do :

traci.person.replaceStage(personID, stageIndex, traciStage

For future modifications, i'd like to replace the namedtuple Stage with a proper class (because a named tuple is not mutable). Is this okey ?

Signed-off-by: tarek chouaki tarek.chouaki@irt-systemx.fr

tarek chouaki
traci.person.replaceStage(personId, stageIndex, traciStage")
Signed-off-by: tarek chouaki <tarek.chouaki@irt-systemx.fr>
@namdre

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

Yes. Replacing the namedtuple is already planned: #5523. Feel free to add another pull request for that.

@tkchouaki

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

I'll do it as soon as this one gets merged to avoid conflicts.

@namdre namdre merged commit 014162d into eclipse:master Jul 3, 2019

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
eclipsefdn/eca The author(s) of the pull request is covered by necessary legal agreements in order to proceed!
Details
namdre added a commit that referenced this pull request Jul 4, 2019
namdre added a commit that referenced this pull request Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.