sha2/sha2.c: fix build on big endian#37
Merged
Merged
Conversation
Build is broken since 865ec9b because tmp is undefined in put32be and put64be: /home/buildroot/autobuild/instance-1/output-1/host/bin/m68k-linux-gcc -DSHA2_USE_INTTYPES_H -Wall -std=c99 -pedantic -fPIC -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -DDTLSv12 -DWITH_SHA256 -I.. -c -o sha2.o sha2.c sha2.c: In function 'get32be': sha2.c:164:2: warning: implicit declaration of function 'MEMCPY_BCOPY' [-Wimplicit-function-declaration] MEMCPY_BCOPY(&tmp, data, sizeof(tmp)); ^~~~~~~~~~~~ sha2.c: In function 'put32be': sha2.c:177:34: error: 'tmp' undeclared (first use in this function) MEMCPY_BCOPY(data, &val, sizeof(tmp)); ^~~ Fix this error by replacing tmp by val Moreover, move MEMCPY_BCOPY before its usage or linking step will fail Fixes: - http://autobuild.buildroot.org/results/e8704e02fdede7b63e22da552292977b23380b32 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build is broken since 865ec9b because tmp is undefined in put32be and put64be:
Fix this error by replacing tmp by val
Moreover, move MEMCPY_BCOPY before its usage or linking step will fail
Fixes:
Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com