Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Eclipse-light theme with the classic Eclipse colors #215

Merged
merged 1 commit into from Jul 22, 2019

Conversation

@jonas-jonas
Copy link
Member

commented Jul 22, 2019

This PR aligns the colors of the Eclipse-light theme with the colors of the classic Eclipse Java editor theme. I tested it locally with a Dart file. See images for comparisons.

Without my patch:
eclipse-light-old

With my patch (see "void" keyword and less yellow, which is not part of the origin color theme):
eclipse-light-new

Classic Eclipse Java colors:
eclipse-light-original

Signed-off-by: Jonas Hungershausen jonas.hungershausen@vogella.com

Align Eclipse-light theme with the classic Eclipse colors
Signed-off-by: Jonas Hungershausen <jonas.hungershausen@vogella.com>

@mickaelistria mickaelistria merged commit dd584a3 into eclipse:master Jul 22, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
eclipsefdn/eca The author(s) of the pull request is covered by necessary legal agreements in order to proceed!
Details
@mickaelistria

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

Very good, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.