Feature/range send file #1115
Merged
Feature/range send file #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -439,7 +439,7 @@ private void doSendFile(String filename, Handler<AsyncResult<Void>> resultHandle | |||
| try { | |||
| raf = new RandomAccessFile(file, "r"); | |||
| conn.queueForWrite(response); | |||
| conn.sendFile(raf, fileLength); | |||
| conn.sendFile(raf, Math.min(offset, fileLength), Math.min(length, fileLength - offset)); | |||
There was a problem hiding this comment.
duplicate calculation. can be done once higher up in method.
|
i've ammended the branch... |
| @@ -230,6 +230,36 @@ public void testSendFileFromClasspath() { | |||
| await(); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testSendOpenRangeFileFromClasspath() { | |||
There was a problem hiding this comment.
I think it would be more appropriate to have these tests in HttpTest with the rest of the send file tests.
We do have some send file tests in FileResolverTest but these are just to make sure the offsetting is working ok.
Signed-off-by: Paulo Lopes <paulo@mlopes.net>
Signed-off-by: Paulo Lopes <paulo@mlopes.net>
| } | ||
|
|
||
| /** | ||
| * Ask the OS to stream a file as specified by {@code filename} directly |
There was a problem hiding this comment.
When creating an overloaded method, instead of duplicating the javadoc, it's preferable to use {@link} to refer to the version with the full javadoc and just explain the differences.
|
Also, we should probably have something in the docs (package-info.java in the http package) about this. |
Signed-off-by: Paulo Lopes <paulo@mlopes.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement range support for streaming files.
Once this is in we can support: