Permalink
Browse files

[284508] Server will not change to republish status after web module …

…changed
  • Loading branch information...
1 parent 3b563e3 commit 4174194ad2f0f9629a195218b7ce50ae1a618612 david_williams committed Jul 27, 2009
@@ -4,19 +4,20 @@
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="Build" content="Build">
- <title>WTP 3.0.5 Patches</title>
+ <title>WTP 3.0.5.1 Patches</title>
</head>
<body>
-<h1>WTP 3.0.5 Patches</h1>
+<h1>WTP 3.0.5.1 Patches</h1>
<h2>Feature Patched: org.eclipse.wst.server_core.feature</h2>
<h3>Plugin(s) replaced:</h3>
<ul><li>org.eclipse.wst.server.core</li></ul>
<p>Bug <a href='https://bugs.eclipse.org/279110'>279110</a>. Server status stuck on 'Republish'</p>
<ul><li>org.eclipse.wst.internet.monitor.core</li></ul>
<p>Bug <a href='https://bugs.eclipse.org/279101'>279101</a>. TCP/IP HTTP parser is case sensitive, when the specs say it shouldn't be</p>
+<p>Bug <a href='https://bugs.eclipse.org/284508'>284508</a>. Server will not change to republish status after web module changed</p>
</body></html>
@@ -29,6 +29,7 @@ Contains fixes described in the following bugzilla(s):\n\
\n\
Bug https://bugs.eclipse.org/279101 TCP/IP HTTP parser is case sensitive, when the specs say it shouldn't be\n\
Bug https://bugs.eclipse.org/279110 Server status stuck on 'Republish'\n\
+Bug https://bugs.eclipse.org/284508 Server will not change to republish status after web module changed\n\
\n\
# "copyright" property - text of the "Feature Update Copyright"
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: %pluginName
Bundle-SymbolicName: org.eclipse.wst.server.core; singleton:=true
-Bundle-Version: 1.1.5.qualifier
+Bundle-Version: 1.1.6.qualifier
Bundle-Activator: org.eclipse.wst.server.core.internal.ServerPlugin
Bundle-Vendor: %providerName
Bundle-Localization: plugin
@@ -798,20 +798,26 @@ protected boolean isModuleDeployed(final IModule requestedModule){
return false;
// shallow search: check for root modules first
- boolean rv = modules.contains(requestedModule);
-
- // deep search: look into all the child modules
- rv = !visitModule(modules.toArray(new IModule[0]), new IModuleVisitor(){
- public boolean visit(IModule[] modules2) {
- for (int i =0;i<=modules2.length-1;i++){
- if (modules2[i].equals(requestedModule))
- return false;
- }
- return !modules2.equals(requestedModule);
- }}, null);
+ boolean deployed = modules.contains(requestedModule);
+
+ if(!deployed){
+ // deep search: look into all the child modules
+ Iterator<IModule> itr = modules.iterator();
+ while(itr.hasNext() && !deployed){
+ IModule[] m = new IModule[] {itr.next()};
+ deployed = !visitModule(m, new IModuleVisitor(){
+ public boolean visit(IModule[] modules2) {
+ for (int i =0;i<=modules2.length-1;i++){
+ if (modules2[i].equals(requestedModule))
+ return false;
+ }
+ return true;
+ }}, null);
+ }
+ }
- Trace.trace(Trace.FINEST, "< isModuleDeployed() rv="+rv);
- return rv;
+ Trace.trace(Trace.FINEST, "< isModuleDeployed() deployed="+deployed);
+ return deployed;
}
protected void stopAutoPublish() {

0 comments on commit 4174194

Please sign in to comment.