New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wizard] Configure lineDelimiter for CodeConfig #101

Closed
kthoms opened this Issue Sep 14, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@kthoms
Contributor

kthoms commented Sep 14, 2016

The property CodeConfig#lineDelimiter determines the delimiter to use for generated text files and newly also for the manifest file (see bug#378980). The default value is system dependent, which could result in alternating changes to the manifest file, or if checked in also for generated code.

Therefore it is better to set this property, like the encoding, explicitly. The wizard should take the value configured in the workspace preferences as default and add the lineDelimiter property to the MWE2 workflow.

kthoms added a commit to kthoms/xtext-core that referenced this issue Sep 14, 2016

[#101] Configure lineDelimiter in workflows
Add 'lineDelimiter' to project configuration and generate it to the
'code' configuration in the workflow.
Adjusted test expectations.


Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
@spoenemann

This comment has been minimized.

Show comment
Hide comment
@spoenemann

spoenemann Oct 6, 2016

Member

That would require extensions to both xtext-core (org.eclipse.xtext.xtext.wizard) and xtext-eclipse (org.eclipse.xtext.xtext.ui).

Member

spoenemann commented Oct 6, 2016

That would require extensions to both xtext-core (org.eclipse.xtext.xtext.wizard) and xtext-eclipse (org.eclipse.xtext.xtext.ui).

kthoms added a commit to kthoms/xtext-core that referenced this issue Oct 7, 2016

[#101] Configure lineDelimiter in workflows
Add 'lineDelimiter' to project configuration and generate it to the
'code' configuration in the workflow.
Adjusted test expectations.


Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit to kthoms/xtext-core that referenced this issue Oct 7, 2016

[#101] Configure lineDelimiter in workflows
Add 'lineDelimiter' to project configuration and generate it to the
'code' configuration in the workflow.
Adjusted test expectations.


Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

spoenemann added a commit that referenced this issue Oct 10, 2016

Merge pull request #102 from kthoms/kth/issue101
[#101] Configure lineDelimiter in workflows
@kthoms

This comment has been minimized.

Show comment
Hide comment
@kthoms

kthoms Jul 3, 2017

Contributor

Fixed in 2.11

Contributor

kthoms commented Jul 3, 2017

Fixed in 2.11

@kthoms kthoms closed this Jul 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment