Serializer takes "forever" #17

Closed
cdietrich opened this Issue Jun 27, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@cdietrich
Member

cdietrich commented Jun 27, 2016

the serializer seem to take forever in 2.9+

using https://github.com/sculptor/sculptor/tree/develop/sculptor-eclipse with //github.com/vladdu/xtext.unittesting

and running SculptordslValidatorITest

it performs much better when using

import org.eclipse.xtext.util.formallang.Cfg;
import org.eclipse.xtext.util.formallang.FollowerFunction;
import org.eclipse.xtext.util.formallang.FollowerFunctionImpl;
import org.eclipse.xtext.util.formallang.FollowerFunctionImpl.UnorderedStrategy;
import org.eclipse.xtext.util.formallang.Pda;
import org.eclipse.xtext.util.formallang.PdaFactory;
import org.eclipse.xtext.util.formallang.PdaUtil;

@SuppressWarnings("restriction")
public class MyDslPDAUtil extends PdaUtil {

    @Override
    public <S, P, E, T, D extends Pda<S, P>> D create(Cfg<E, T> cfg, FollowerFunction<E> ff,
            PdaFactory<D, S, P, ? super E> fact) {
        ((FollowerFunctionImpl<E, T>)ff).setUnorderedStrategy(UnorderedStrategy.SEQUENCE);
        return super.create(cfg, ff, fact);
    }

}

and

    public Class<? extends PdaUtil> bindPdaUtil() {
        return MyDslPDAUtil.class;
    }
@spoenemann

This comment has been minimized.

Show comment
Hide comment
@spoenemann

spoenemann Oct 6, 2016

Member

@meysholdt you planned to work on this, right?

Member

spoenemann commented Oct 6, 2016

@meysholdt you planned to work on this, right?

@cdietrich

This comment has been minimized.

Show comment
Hide comment
@cdietrich

cdietrich Nov 1, 2016

Member

@meysholdt i had a look with 2.11 and the performance seems much better with 2.11. same for memory consumption

Member

cdietrich commented Nov 1, 2016

@meysholdt i had a look with 2.11 and the performance seems much better with 2.11. same for memory consumption

@kthoms

This comment has been minimized.

Show comment
Hide comment
@kthoms

kthoms Nov 16, 2016

Contributor

@meysholdt Is this also related to https://bugs.eclipse.org/bugs/show_bug.cgi?id=484465 and e8682fb ?
Could this one be closed now?

Contributor

kthoms commented Nov 16, 2016

@meysholdt Is this also related to https://bugs.eclipse.org/bugs/show_bug.cgi?id=484465 and e8682fb ?
Could this one be closed now?

@meysholdt

This comment has been minimized.

Show comment
Hide comment
@meysholdt

meysholdt Dec 6, 2016

Contributor

from my side, this can be closed. @cdietrich, do you agree that the problem for which you filed this issue has been resolved?

Contributor

meysholdt commented Dec 6, 2016

from my side, this can be closed. @cdietrich, do you agree that the problem for which you filed this issue has been resolved?

@cdietrich

This comment has been minimized.

Show comment
Hide comment
@cdietrich

cdietrich Dec 6, 2016

Member

yes looks good now

Member

cdietrich commented Dec 6, 2016

yes looks good now

@cdietrich cdietrich closed this Dec 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment