New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refined token placement for indentation based languages #366

Merged
merged 17 commits into from Sep 5, 2017

Conversation

Projects
None yet
2 participants
@szarnekow
Contributor

szarnekow commented Jun 13, 2017

This improves token placement for INDENT / DEDENT tokens (see NodeModelTest).
The refinement is the foundation for improved content assist behavior. Therefore, this
PR fixes #342.

Noteworthy changes:

  • ContentAssistContextFactory uses a CompletionPrefixProvider that can be specialized for ws based languages (see IndentationAwareCompletionPrefixProvider).
  • LeafNodeFinder was refactored to handle empty leaf nodes, too
@szarnekow

This comment has been minimized.

Show comment
Hide comment
@szarnekow

szarnekow Jun 14, 2017

Contributor

Please review.

Contributor

szarnekow commented Jun 14, 2017

Please review.

@szarnekow

This comment has been minimized.

Show comment
Hide comment
@szarnekow

szarnekow Aug 17, 2017

Contributor

@cdietrich I added the since tags. Anything else that appears to be fishy here?

Contributor

szarnekow commented Aug 17, 2017

@cdietrich I added the since tags. Anything else that appears to be fishy here?

name=ID
(INDENT
children+=TreeNode*
DEDENT)?

This comment has been minimized.

@cdietrich

cdietrich Aug 17, 2017

Member

outdent ??? ;)

@cdietrich

cdietrich Aug 17, 2017

Member

outdent ??? ;)

@szarnekow szarnekow merged commit 1c5b2b0 into master Sep 5, 2017

1 check passed

ip-validation
Details

cdietrich added a commit that referenced this pull request Sep 6, 2017

Merge pull request #366 from eclipse/sz_bug476690
Refined token placement for indentation based languages

@kthoms kthoms deleted the sz_bug476690 branch Oct 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment