[378980] Make line delimiter for Manifest configurable by CodeConfig

[kthoms]

Line delimiter is determined by CodeConfig and reached into MergeableManifest.

Signed-off-by: Karsten Thoms karsten.thoms@itemis.de

[eclipsewebmaster]

Issue tracker reference:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=378980

[meysholdt]

\r\n is hard-coded in java.util.jar.Manifest.write(OutputStream), even though the spec allows for \r\n and \n

[kthoms]

Right, I was not aware of that. So does this mean since standard Java Manifest uses \r\n it is also mandatory for MergeableManifest to do the same? Seems so, i.e. I should close the bug as WONTFIX?

[meysholdt]

Further investigation shows that java.util.jar.Manifest.read(InputStream) supports both \r\n and \n. Also, the Eclipse Manifest Editor supports both \r\n and \n\. Furthermore, the MANIFEST.MFs in xtext-core only contain \n. So I'm fine with making line-edings configurable in MergeableManifest.

Can you confirm that your change doesn't mix line-edings, e.g. because a method from the super-class (Manifest) adds \r\n but in MergeableManifest \n is configured?

[kthoms]

This is how it looks like after generating. The example above is without any configuration, it will use Strings.newLine() by default which is "\n". You can see all line endings are such.

The second example shows explicit configuration of "\r\n". Again, all line endings are the same.

[meysholdt]

this filed is only used by deprecated methods, right? Then it should be deprecated itself.

[kthoms]

Correct, it is only used in deprecated contexts. Will fix that.

[meysholdt]

thx!

[kthoms]

Thanks for the review :)