New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute org.eclipse.core.contenttype.contentTypes extension #379

Closed
kthoms opened this Issue Sep 25, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@kthoms
Contributor

kthoms commented Sep 25, 2017

A text search can result in blocking behavior when trying to determine if a file has binary content. In org.eclipse.search.internal.core.text.TextSearchVisitor.hasBinaryContent(CharSequence, IFile) it is first tried to get a content description for a file. If there is none, the file's beginning is read to detect \0.

The following screenshot shows that TextSearchVisitor.hasBinaryContent is quite heavy weight and blocked in the synchronized method java.nio.charset.CoderResult.Cache.get(int).

For Xtext DSLs this can be improved by contributing a content description.

screenshot 47

@cdietrich

This comment has been minimized.

Show comment
Hide comment
@cdietrich

cdietrich Sep 26, 2017

Member

am missing a commit for existing dsl like xtext xbase purexbase xtend etc

Member

cdietrich commented Sep 26, 2017

am missing a commit for existing dsl like xtext xbase purexbase xtend etc

@kthoms

This comment has been minimized.

Show comment
Hide comment
@kthoms

kthoms Sep 26, 2017

Contributor

ok, will contribute

Contributor

kthoms commented Sep 26, 2017

ok, will contribute

@kthoms kthoms changed the title from [performance] Contribute org.eclipse.core.contenttype.contentTypes extension to Contribute org.eclipse.core.contenttype.contentTypes extension Sep 27, 2017

@kthoms kthoms added the performance label Sep 27, 2017

kthoms added a commit that referenced this issue Sep 27, 2017

[#379] Contribute org.eclipse.core.contenttype.contentTypes
Regenerated Testlanguages

Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit that referenced this issue Sep 27, 2017

[#379] Contribute org.eclipse.core.contenttype.contentTypes
Regenerated Testlanguages
Regenerated PureXbase

Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit that referenced this issue Sep 28, 2017

Merge pull request #381 from eclipse/kth_issue379_testlang
[#379] Contribute org.eclipse.core.contenttype.contentTypes

@cdietrich cdietrich added this to the Release_2.13 milestone Sep 28, 2017

kthoms added a commit to eclipse/xtext-xtend that referenced this issue Sep 28, 2017

[eclipse/xtext-eclipse#379] Contribute Content Type
extension org.eclipse.core.contenttype.contentTypes for Xtend files
added.

Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit to eclipse/xtext-xtend that referenced this issue Sep 28, 2017

@kthoms

This comment has been minimized.

Show comment
Hide comment
@kthoms

kthoms Sep 28, 2017

Contributor

Done.

Contributor

kthoms commented Sep 28, 2017

Done.

@kthoms kthoms closed this Sep 28, 2017

gallandarakhneorg added a commit to sarl/sarl that referenced this issue Dec 22, 2017

[ui] Add Eclipse extension for detecting SARL files faster.
Xtext UI projects provide a Content Type Descriptor within
the plugin.xml file. This is affecting performance on text
searches in Eclipse, since Eclipse can decide that a DSL file
has no binary content based on the content type’s base type

see eclipse/xtext-eclipse#379
close #780

Signed-off-by: Stéphane Galland <galland@arakhne.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment