New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Copyright Headers #1160

Closed
kthoms opened this Issue Jan 15, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@kthoms
Contributor

kthoms commented Jan 15, 2018

The copyright headers should be updated. Eclipse Copyright Header guidelines are here:
https://www.eclipse.org/projects/handbook/#ip-copyright-headers

  • The copyright date should reflect the last commit year. We have to take the repository split into account. As a first approach we should only update files that changed after the split. I guess 2016-AUG-01 is a good cutoff date.
  • Some copyright headers contain errors in the text. For example, I found occurances like
    • under the terms of the Eclipse def License v1.0
    • under the terms of the Eclipse License v1.0
  • The headers should contain the SPDX-License-Identifier
  • The term 'All rights reserved' is not necessary. It could be left as is or we could remove it. Newer files should not contain it anymore.

@kthoms kthoms added the releng label Jan 15, 2018

kthoms added a commit to eclipse/xtext-xtend that referenced this issue Jan 15, 2018

[eclipse/xtext#1160] Fixed license name
Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit to eclipse/xtext-core that referenced this issue Jan 15, 2018

[eclipse/xtext#1160] Fixed license name
Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit to eclipse/xtext-extras that referenced this issue Jan 15, 2018

[eclipse/xtext#1160] Fixed license name
Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

@cdietrich cdietrich added this to the Release_2.14 milestone Jan 15, 2018

kthoms added a commit to eclipse/xtext-lib that referenced this issue Jan 15, 2018

[eclipse/xtext#1160] Update copyright date range
Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit to eclipse/xtext-lib that referenced this issue Jan 15, 2018

kthoms added a commit to eclipse/xtext-core that referenced this issue Jan 15, 2018

[eclipse/xtext#1160] Update copyright date range
Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit to eclipse/xtext-extras that referenced this issue Jan 15, 2018

[eclipse/xtext#1160] Update copyright date range
Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit to eclipse/xtext-eclipse that referenced this issue Jan 15, 2018

[eclipse/xtext#1160] Update copyright date range
Additional cleanup for some files:
- remove empty line at end of file
- move package statement below copyright header

Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit to eclipse/xtext-xtend that referenced this issue Jan 15, 2018

[eclipse/xtext#1160] Update copyright date range
Additional file cleanup
- remove empty line at end of file

Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit to eclipse/xtext-web that referenced this issue Jan 15, 2018

[eclipse/xtext#1160] Update copyright date range
Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit to eclipse/xtext-idea that referenced this issue Jan 15, 2018

[eclipse/xtext#1160] Update copyright date range
Additional file cleanup:
- remove empty line at end of file

Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit to eclipse/xtext-core that referenced this issue Jan 16, 2018

kthoms added a commit to eclipse/xtext-extras that referenced this issue Jan 16, 2018

kthoms added a commit to eclipse/xtext-web that referenced this issue Jan 16, 2018

kthoms added a commit to eclipse/xtext-core that referenced this issue Jan 16, 2018

[eclipse/xtext#1160] Update copyright date range
Recompiled Xtend files

Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit to eclipse/xtext-core that referenced this issue Jan 16, 2018

[eclipse/xtext#1160] Fixed test expectation
Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit to eclipse/xtext-lib that referenced this issue Jan 16, 2018

[eclipse/xtext#1160] Updated copyright date range
Recompiled Xtend files

Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit to eclipse/xtext-extras that referenced this issue Jan 16, 2018

[eclipse/xtext#1160] Update copyright date range
Recompiled Xtend files

Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit to eclipse/xtext-core that referenced this issue Jan 16, 2018

kthoms added a commit to eclipse/xtext-lib that referenced this issue Jan 16, 2018

kthoms added a commit to eclipse/xtext-xtend that referenced this issue Jan 16, 2018

[eclipse/xtext#1160] Update copyright date range
Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit to eclipse/xtext-xtend that referenced this issue Jan 16, 2018

[eclipse/xtext#1160] Update copyright date range
Recompiled Xtend files

Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit to eclipse/xtext-extras that referenced this issue Jan 16, 2018

kthoms added a commit to eclipse/xtext-eclipse that referenced this issue Jan 16, 2018

[eclipse/xtext#1160] Update copyright date range
Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit to eclipse/xtext-eclipse that referenced this issue Jan 16, 2018

[eclipse/xtext#1160] Update copyright date range
Recompiled Xtend files

Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit to eclipse/xtext-xtend that referenced this issue Jan 16, 2018

kthoms added a commit to eclipse/xtext-idea that referenced this issue Jan 16, 2018

[eclipse/xtext#1160] Update copyright date range
Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
@cdietrich

This comment has been minimized.

Show comment
Hide comment
@cdietrich

cdietrich Jan 22, 2018

Member

@kthoms anything left?

Member

cdietrich commented Jan 22, 2018

@kthoms anything left?

@kthoms

This comment has been minimized.

Show comment
Hide comment
@kthoms

kthoms Jan 22, 2018

Contributor

Feature descriptors in umbrella are missing. Will provide a PR.

Contributor

kthoms commented Jan 22, 2018

Feature descriptors in umbrella are missing. Will provide a PR.

kthoms added a commit to eclipse/xtext-umbrella that referenced this issue Jan 22, 2018

[eclipse/xtext#1160] Update copyright date range
Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit to eclipse/xtext-umbrella that referenced this issue Jan 22, 2018

kthoms added a commit to eclipse/xtext-lib that referenced this issue Jan 22, 2018

[eclipse/xtext#1160] Update copyright date range
Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit to eclipse/xtext-lib that referenced this issue Jan 22, 2018

kthoms added a commit to eclipse/xtext-xtend that referenced this issue Jan 22, 2018

[eclipse/xtext#1160] Fixed license name
Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
@kthoms

This comment has been minimized.

Show comment
Hide comment
@kthoms

kthoms Jan 22, 2018

Contributor

I think we are done for the first round. We may add SPDX-License-Identifier and do more harmonizing later with a seperate issue.

Contributor

kthoms commented Jan 22, 2018

I think we are done for the first round. We may add SPDX-License-Identifier and do more harmonizing later with a seperate issue.

@kthoms kthoms closed this Jan 22, 2018

kthoms added a commit to eclipse/xtext-xtend that referenced this issue Jan 23, 2018

[eclipse/xtext#1160] Update copyright date range
Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit to eclipse/xtext-eclipse that referenced this issue Jan 23, 2018

@kthoms kthoms reopened this Jan 23, 2018

@kthoms

This comment has been minimized.

Show comment
Hide comment
@kthoms

kthoms Jan 23, 2018

Contributor

Some files in xtend-gen folders have been changed manually with the changes. The copyright date is derived from the Xtend sources, so some files are changing on recompilation.

Contributor

kthoms commented Jan 23, 2018

Some files in xtend-gen folders have been changed manually with the changes. The copyright date is derived from the Xtend sources, so some files are changing on recompilation.

@cdietrich

This comment has been minimized.

Show comment
Hide comment
@cdietrich

cdietrich Jan 23, 2018

Member

as discussed last week the state in the source file should be deciding

Member

cdietrich commented Jan 23, 2018

as discussed last week the state in the source file should be deciding

kthoms added a commit to eclipse/xtext-xtend that referenced this issue Jan 23, 2018

[eclipse/xtext#1160] Update copyright date range
Recompiled from Xtend source

Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>

kthoms added a commit to eclipse/xtext-xtend that referenced this issue Jan 23, 2018

@kthoms kthoms closed this Jan 23, 2018

kthoms added a commit to eclipse/xtext-idea that referenced this issue Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment