Skip to content
This repository has been archived by the owner before Nov 9, 2022. It is now read-only.

Review translations for errors/brand misuse #225

Closed
autumnfound opened this issue Apr 27, 2021 · 2 comments
Closed

Review translations for errors/brand misuse #225

autumnfound opened this issue Apr 27, 2021 · 2 comments
Assignees

Comments

@autumnfound
Copy link
Contributor

autumnfound commented Apr 27, 2021

When revieweing some translations, we encountered a few small errors at a glance. They have been mostly corrected, but we should make a concerted effort to review all of the translations to look for things such as typos or misuse of the brand (such as translating Foundation in Eclipse Foundation).

@autumnfound autumnfound self-assigned this Apr 28, 2021
@autumnfound
Copy link
Contributor Author

autumnfound commented Apr 30, 2021

From Sharon M. regarding copyright and usage of the Eclipse Foundation trademark:

For trademarks we are only protected when we use wordmarks and design marks exactly as filed. Any different versions that were translated would not be considered use of our registered marks.

In keeping with this, I created a quick script to scan for various issues across our i18n files. I've included below the report that it spit out.

Language 'en' had 117 keys
Skipping processing of 'en' as it is the configured base lang.

Language 'es' had 62 keys
Good keys for es: 44
Issues:
        - ERR1: Key 'upcoming-events-header' does not exist in base 'en' file (but exists in 'es')
        - ERR1: Key 'upcoming-events-learn-more' does not exist in base 'en' file (but exists in 'es')
        - ERR1: Key 'upcoming-events-learn-more-title' does not exist in base 'en' file (but exists in 'es')
        - ERR1: Key 'past-events-header' does not exist in base 'en' file (but exists in 'es')
        - ERR1: Key 'past-events-learn-more' does not exist in base 'en' file (but exists in 'es')
        - ERR1: Key 'past-events-learn-more-title' does not exist in base 'en' file (but exists in 'es')
        - ERR1: Key 'agenda-abstract-modal-alt' does not exist in base 'en' file (but exists in 'es')
        - ERR1: Key 'agenda-modal-close-alt' does not exist in base 'en' file (but exists in 'es')
        - ERR1: Key 'speakers-tiles-title' does not exist in base 'en' file (but exists in 'es')
        - ERR1: Key 'committee-carousel-content' does not exist in base 'en' file (but exists in 'es')
        - ERR1: Key 'footer-get-social-title' does not exist in base 'en' file (but exists in 'es')
        - ERR1: Key 'footer-our-events-title' does not exist in base 'en' file (but exists in 'es')
        - ERR1: Key 'footer-get-social-content' does not exist in base 'en' file (but exists in 'es')
        - ERR1: Key 'footer-jakarta-callout-content' does not exist in base 'en' file (but exists in 'es')
        - ERR1: Key 'footer-jakarta-callout-button-text' does not exist in base 'en' file (but exists in 'es')
        - WARN: Key 'footer-legal-section-text' has the same value in 'es' as base en
        - WARN: Key 'footer-useful-links-forums-text' has the same value in 'es' as base en
        - WARN: Key 'navigation-breadcrumb-sr' has the same value in 'es' as base en


Language 'jp' had 60 keys
Good keys for jp: 45
Issues:
        - ERR1: Key 'upcoming-events-header' does not exist in base 'en' file (but exists in 'jp')
        - ERR1: Key 'upcoming-events-learn-more' does not exist in base 'en' file (but exists in 'jp')
        - ERR1: Key 'upcoming-events-learn-more-title' does not exist in base 'en' file (but exists in 'jp')
        - ERR1: Key 'past-events-header' does not exist in base 'en' file (but exists in 'jp')
        - ERR1: Key 'past-events-learn-more' does not exist in base 'en' file (but exists in 'jp')
        - ERR1: Key 'past-events-learn-more-title' does not exist in base 'en' file (but exists in 'jp')
        - ERR1: Key 'agenda-abstract-modal-alt' does not exist in base 'en' file (but exists in 'jp')
        - ERR1: Key 'agenda-modal-close-alt' does not exist in base 'en' file (but exists in 'jp')
        - ERR1: Key 'committee-carousel-content' does not exist in base 'en' file (but exists in 'jp')
        - ERR1: Key 'footer-get-social-title' does not exist in base 'en' file (but exists in 'jp')
        - ERR1: Key 'footer-get-social-content' does not exist in base 'en' file (but exists in 'jp')
        - ERR1: Key 'footer-our-events-title' does not exist in base 'en' file (but exists in 'jp')
        - ERR1: Key 'footer-jakarta-callout-content' does not exist in base 'en' file (but exists in 'jp')
        - ERR1: Key 'footer-jakarta-callout-button-text' does not exist in base 'en' file (but exists in 'jp')
        - WARN: Key 'eclipse-foundation-text' has the same value in 'jp' as base en


Language 'pt' had 62 keys
Good keys for pt: 35
Issues:
        - ERR1: Key 'upcoming-events-header' does not exist in base 'en' file (but exists in 'pt')
        - ERR1: Key 'upcoming-events-learn-more' does not exist in base 'en' file (but exists in 'pt')
        - ERR1: Key 'upcoming-events-learn-more-title' does not exist in base 'en' file (but exists in 'pt')
        - ERR1: Key 'past-events-header' does not exist in base 'en' file (but exists in 'pt')
        - ERR1: Key 'past-events-learn-more' does not exist in base 'en' file (but exists in 'pt')
        - ERR1: Key 'past-events-learn-more-title' does not exist in base 'en' file (but exists in 'pt')
        - ERR1: Key 'agenda-abstract-modal-alt' does not exist in base 'en' file (but exists in 'pt')
        - ERR1: Key 'agenda-modal-close-alt' does not exist in base 'en' file (but exists in 'pt')
        - ERR1: Key 'speakers-tiles-title' does not exist in base 'en' file (but exists in 'pt')
        - ERR1: Key 'committee-carousel-content' does not exist in base 'en' file (but exists in 'pt')
        - ERR1: Key 'footer-get-social-title' does not exist in base 'en' file (but exists in 'pt')
        - ERR1: Key 'footer-our-events-title' does not exist in base 'en' file (but exists in 'pt')
        - ERR1: Key 'footer-get-social-content' does not exist in base 'en' file (but exists in 'pt')
        - ERR1: Key 'footer-jakarta-callout-content' does not exist in base 'en' file (but exists in 'pt')
        - ERR1: Key 'footer-jakarta-callout-button-text' does not exist in base 'en' file (but exists in 'pt')
        - WARN: Key 'footer-legal-section-text' has the same value in 'pt' as base en
        - WARN: Key 'footer-legal-copyright-agent-text' has the same value in 'pt' as base en
        - WARN: Key 'footer-legal-epl-text' has the same value in 'pt' as base en
        - WARN: Key 'footer-legal-resources-text' has the same value in 'pt' as base en
        - WARN: Key 'footer-useful-links-section-text' has the same value in 'pt' as base en
        - WARN: Key 'footer-useful-links-mailing-list-text' has the same value in 'pt' as base en
        - WARN: Key 'footer-useful-links-marketplace-text' has the same value in 'pt' as base en
        - WARN: Key 'footer-other-working-groups-text' has the same value in 'pt' as base en
        - WARN: Key 'footer-other-research-text' has the same value in 'pt' as base en
        - WARN: Key 'footer-other-status-text' has the same value in 'pt' as base en
        - WARN: Key 'navigation-back-to-top' has the same value in 'pt' as base en
        - WARN: Key 'navigation-breadcrumb-sr' has the same value in 'pt' as base en


Language 'ru' had 117 keys
Good keys for ru: 109
Issues:
        - WARN: Key 'eclipse-foundation-text' has the same value in 'ru' as base en
        - WARN: Key 'footer-legal-copyright-agent-text' has the same value in 'ru' as base en
        - WARN: Key 'footer-legal-epl-text' has the same value in 'ru' as base en
        - WARN: Key 'footer-other-research-text' has the same value in 'ru' as base en
        - WARN: Key 'navigation-more-participate-wiki-label' has the same value in 'ru' as base en
        - WARN: Key 'navigation-more-participate-irc-label' has the same value in 'ru' as base en
        - WARN: Key 'navigation-more-ide-section' has the same value in 'ru' as base en
        - WARN: Key 'not-found-template-eclipse-home' has the same value in 'ru' as base en


Language 'tr' had 117 keys
Good keys for tr: 106
Issues:
        - ERR3: Key 'eclipse-foundation-text' value contains 'Eclipse Foundation' in 'en' but not in 'tr'
        - WARN: Key 'footer-other-research-text' has the same value in 'tr' as base en
        - WARN: Key 'navigation-breadcrumb-sr' has the same value in 'tr' as base en
        - WARN: Key 'navigation-more-community-planet-eclipse-label' has the same value in 'tr' as base en
        - WARN: Key 'navigation-more-participate-wiki-label' has the same value in 'tr' as base en
        - WARN: Key 'navigation-more-participate-irc-label' has the same value in 'tr' as base en
        - WARN: Key 'navigation-more-ide-section' has the same value in 'tr' as base en
        - ERR3: Key 'footer-copyright-text' value contains 'Eclipse Foundation' in 'en' but not in 'tr'
        - WARN: Key 'project-summary-logo-text' has the same value in 'tr' as base en
        - WARN: Key 'project-list-logo-alt' has the same value in 'tr' as base en
        - WARN: Key 'events-sponsor-image-alt' has the same value in 'tr' as base en


Language 'zh' had 130 keys
Good keys for zh: 114
Issues:
        - ERR1: Key 'relative-links' does not exist in base 'en' file (but exists in 'zh')
        - ERR3: Key 'eclipse-foundation-text' value contains 'Eclipse Foundation' in 'en' but not in 'zh'
        - ERR1: Key 'jakarta-ee-website' does not exist in base 'en' file (but exists in 'zh')
        - ERR1: Key 'jakartaee-ambassodars' does not exist in base 'en' file (but exists in 'zh')
        - ERR1: Key 'jakartaone-website' does not exist in base 'en' file (but exists in 'zh')
        - ERR1: Key 'footer-useful-links-committee' does not exist in base 'en' file (but exists in 'zh')
        - ERR1: Key 'footer-useful-links-newsletter' does not exist in base 'en' file (but exists in 'zh')
        - ERR1: Key 'footer-useful-links-minutes' does not exist in base 'en' file (but exists in 'zh')
        - ERR1: Key 'footer-useful-links-googledrive' does not exist in base 'en' file (but exists in 'zh')
        - ERR1: Key 'footer-other-codeofconduct' does not exist in base 'en' file (but exists in 'zh')
        - ERR1: Key 'footer-other-ambassodars' does not exist in base 'en' file (but exists in 'zh')
        - ERR1: Key 'footer-other-charter' does not exist in base 'en' file (but exists in 'zh')
        - ERR1: Key 'footer-other-membership' does not exist in base 'en' file (but exists in 'zh')
        - ERR1: Key 'footer-other-compatibility' does not exist in base 'en' file (but exists in 'zh')
        - WARN: Key 'navigation-more-ide-section' has the same value in 'zh' as base en
        - ERR3: Key 'footer-copyright-text' value contains 'Eclipse Foundation' in 'en' but not in 'zh'


Issues discovered: 95

In particular, the concerns in this file are the issues labelled as ERR3:

        - ERR3: Key 'eclipse-foundation-text' value contains 'Eclipse Foundation' in 'en' but not in 'tr'
        - ERR3: Key 'eclipse-foundation-text' value contains 'Eclipse Foundation' in 'en' but not in 'tr'
        - ERR3: Key 'eclipse-foundation-text' value contains 'Eclipse Foundation' in 'en' but not in 'zh'
        - ERR3: Key 'footer-copyright-text' value contains 'Eclipse Foundation' in 'en' but not in 'zh'

Overall we are in a decent state, and we can wipe those keys and retranslate them in order to protect our copyright/trademark.

autumnfound added a commit to autumnfound/hugo-solstice-theme that referenced this issue May 5, 2021
Revert 4 keys in zh/tr to remove brand misuse. Added script to help determine issues with translation files beyond what is provided by default.
autumnfound added a commit that referenced this issue May 14, 2021
Revert 4 keys in zh/tr to remove brand misuse. Added script to help determine issues with translation files beyond what is provided by default.
autumnfound added a commit to autumnfound/hugo-solstice-theme that referenced this issue May 14, 2021
Revert 4 keys in zh/tr to remove brand misuse. Added script to help determine issues with translation files beyond what is provided by default.
@autumnfound
Copy link
Contributor Author

autumnfound commented May 19, 2021

This has been merged in

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant