Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Debugger to J2V8 project #414

Open
AlexTrotsenko opened this issue Oct 1, 2018 · 2 comments
Open

Include Debugger to J2V8 project #414

AlexTrotsenko opened this issue Oct 1, 2018 · 2 comments

Comments

@AlexTrotsenko
Copy link

AlexTrotsenko commented Oct 1, 2018

I have created initial version of j2v8-debugger using Stetho for communication with Chrome DevTools as it was sugessted in #293.

Definitely current functionality is limited and there are some known issues.
But in general, most important features are implemented: set/remove breakpoint, step in, step out, step over and ability to see local variables is implemented.
Thus it could be already useful in debugging some complex JS issues.

This debugger could be included to J2V8 project if you find it appropriate. Otherwise it could be kept separately.
What I am not sure is licensing - degugger uses Stetho from Facebook (for communication in Chrome DevTools protocol over web-socket). While j2v8 is licensed under Eclipse Public License v1.

@liruidong183
Copy link

I have created initial version of j2v8-debugger using Stetho for communication with Chrome DevTools as it was sugessted in #293.

Definitely current functionality is limited and there are some known issues.
But in general, most important features are implemented: set/remove breakpoint, step in, step out, step over and ability to see local variables is implemented.
Thus it could be already useful in debugging some complex JS issues.

This debugger could be included to J2V8 project if you find it appropriate. Otherwise it could be kept separately.
What I am not sure is licensing - degugger uses Stetho from Facebook (for communication in Chrome DevTools protocol over web-socket). While j2v8 is licensed under Eclipse Public License v1.

Thanks anyway. I'll integrate it with my project in the latest days.

@artcodex
Copy link

@AlexTrotsenko Thanks for debugging work, playing with this in some projects. I know the functionality there is still evolving, but @irbull would I be wrong in saying some of the support functionality on j2v8 is also not present to support certain scenarios like evaluate evaluateOnCallFrame used for watch variables? If it is maybe I am missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants