diff --git a/app/src/components/core/metaschema/metaSchema.ts b/app/src/components/core/metaschema/metaSchema.ts index 3212116..cdcf57f 100644 --- a/app/src/components/core/metaschema/metaSchema.ts +++ b/app/src/components/core/metaschema/metaSchema.ts @@ -60,7 +60,7 @@ module app.core.metaschema { // child definitions var notGeneratedChildDefinitions = acceptedElements.filter(function (name:string) { - return !_.contains(rootDefinitionsNames, name) && !_.contains(alreadyGenerated, name); + return !_.includes(rootDefinitionsNames, name) && !_.includes(alreadyGenerated, name); }); for (var i = 0; i < notGeneratedChildDefinitions.length; i++) { Metaschema.generateDefinition(definitions, notGeneratedChildDefinitions[i], metaschema, resolvedMetaschema, rootDefinitionsNames, alreadyGenerated); @@ -246,7 +246,7 @@ module app.core.metaschema { */ getDefinitionByTypeLabel(typeLabel:String):Definition { return _.find(this.definitions, (definition:Definition) => { - return _.contains(definition.getTypeLabels(), typeLabel); + return _.includes(definition.getTypeLabels(), typeLabel); }) } diff --git a/app/src/components/core/validation/validator.service.ts b/app/src/components/core/validation/validator.service.ts index 5b1b0ab..a0f722c 100644 --- a/app/src/components/core/validation/validator.service.ts +++ b/app/src/components/core/validation/validator.service.ts @@ -2,7 +2,6 @@ declare var tv4; declare var JsonRefs; module app.core { - import Metaschema = app.core.metaschema.Metaschema; import TreeElement = app.core.model.TreeElement; import IQService = angular.IQService; diff --git a/app/src/components/detail/detail.html b/app/src/components/detail/detail.html index 9426c2b..a32f570 100644 --- a/app/src/components/detail/detail.html +++ b/app/src/components/detail/detail.html @@ -6,7 +6,7 @@
-
diff --git a/app/src/components/preview/preview.html b/app/src/components/preview/preview.html index 9a4e4f0..5d43e57 100644 --- a/app/src/components/preview/preview.html +++ b/app/src/components/preview/preview.html @@ -1,5 +1,5 @@ - diff --git a/backend/config/config.js b/backend/config/config.js index ebdbee2..7ee6b8e 100644 --- a/backend/config/config.js +++ b/backend/config/config.js @@ -1,7 +1,7 @@ var config = {}; -config.appName = "JsonFormEditor"; -config.appUrl = 'https://jsonformseditor.herokuapp.com'; +config.appName = process.env['GITHUB_APP_NAME']; +config.appUrl = process.env['GITHUB_APP_URL']; module.exports = config; \ No newline at end of file diff --git a/backend/config/keys.js b/backend/config/keys.js index fffb50b..0b89976 100644 --- a/backend/config/keys.js +++ b/backend/config/keys.js @@ -4,8 +4,8 @@ var keys = {}; -keys.clientId = "42e0b0e6cf509096ac40"; -keys.clientSecret = "30eed32b0b2ae5732a173ef184ec851b3f668c93"; +keys.clientId = process.env['GITHUB_CLIENT_ID']; +keys.clientSecret = process.env['GITHUB_CLIENT_SECRET']; keys.sessionSecret = "random_key_to_encode_sessions"; diff --git a/bower.json b/bower.json index 95da298..dbcbabd 100644 --- a/bower.json +++ b/bower.json @@ -10,7 +10,6 @@ "angular-ui-router": "^0.2.15", "bootstrap": "~3.3.5", "jquery": "~2.1.4", - "jsonforms": "0.0.15", "material-design-lite": "~1.0.6", "angular-material": "~1.1.0", "ngclipboard": "latest", diff --git a/build.config.js b/build.config.js index ca91664..c73983a 100644 --- a/build.config.js +++ b/build.config.js @@ -68,8 +68,8 @@ module.exports = { 'app/assets/libs/path-loader/browser/path-loader.js', 'app/assets/libs/traverse/traverse.js', 'app/assets/libs/json-refs/browser/json-refs.js', - 'app/assets/libs/tv4/tv4.js', - 'app/assets/libs/jsonforms/dist/js/jsonforms.js', + 'node_modules/tv4/tv4.js', + 'node_modules/jsonforms/dist/jsonforms.js', 'app/assets/libs/material-design-lite/material.js', 'app/assets/libs/angular-animate/angular-animate.js', 'app/assets/libs/angular-aria/angular-aria.js', @@ -87,7 +87,7 @@ module.exports = { 'app/assets/libs/bootstrap/dist/css/bootstrap-theme.css', 'app/assets/libs/material-design-lite/material.css', 'app/assets/libs/angular-material/angular-material.css', - 'app/assets/libs/jsonforms/dist/css/jsonforms.css' + 'node_modules/jsonforms/dist/jsonforms.css' ], assets: [ ] diff --git a/package.json b/package.json index 4dca362..dbe9df5 100644 --- a/package.json +++ b/package.json @@ -6,16 +6,18 @@ "repository": "https://github.com/eclipsesource/JsonFormsEditor", "license": "MIT", "dependencies": { - "bower": "^1.3.1", "body-parser": "~1.13.2", + "bower": "^1.3.1", "cookie-parser": "~1.3.5", "debug": "~2.2.0", "express": "~4.13.1", + "express-session": "1.12.0", + "jsonforms": "1.0.2", "morgan": "~1.6.1", "passport": "0.3.1", "passport-github": "1.1.0", "request": "2.69.0", - "express-session": "1.12.0" + "tv4": "^1.2.7" }, "devDependencies": { "coveralls": "2.11.8", @@ -48,6 +50,7 @@ "remap-istanbul": "latest" }, "scripts": { + "preinstall": "npm install typings -g", "postinstall": "bower install && grunt dist && ./node_modules/protractor/bin/webdriver-manager update" } } diff --git a/typings/lodash/lodash.d.ts b/typings/lodash/lodash.d.ts index 263ee92..823a6ed 100644 --- a/typings/lodash/lodash.d.ts +++ b/typings/lodash/lodash.d.ts @@ -3914,7 +3914,7 @@ declare module _ { ): LoDashExplicitArrayWrapper; } - //_.contains + //_.includes interface LoDashStatic { /** * @see _.includes @@ -5460,7 +5460,7 @@ declare module _ { * Checks if target is in collection using SameValueZero for equality comparisons. If fromIndex is negative, * it’s used as the offset from the end of collection. * - * @alias _.contains, _.include + * @alias _.includes, _.include * * @param collection The collection to search. * @param target The value to search for.