Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance categorization example #1599

Merged
merged 3 commits into from Jul 10, 2020
Merged

Enhance categorization example #1599

merged 3 commits into from Jul 10, 2020

Conversation

TheZoker
Copy link
Collaborator

@TheZoker TheZoker commented Jun 25, 2020 •
edited

@coveralls
Copy link

coveralls commented Jun 25, 2020 •
edited

Coverage Status

Coverage remained the same at 88.961% when pulling b6a3e91 on TheZoker:fix-categorization-example into 34b1e43 on eclipsesource:master.

sdirix
sdirix requested changes Jul 3, 2020
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works ;)

However the current demo feels rather empty. For a better showcase I would prefer having three categories, each with at least 2 controls.

The third one should only show up when the vegetarian checkbox is checked which should be unchecked by default (e.g. change from a HIDE to a SHOW rule) and should contain vegetarian related controls, e.g. 'vegan', 'favoriteVegetable'.

@TheZoker TheZoker mentioned this pull request Jul 9, 2020
Merged
@TheZoker
Copy link
Collaborator Author

TheZoker commented Jul 9, 2020

Done! I updated the example and extended it further. In order to showcase all the new field, the data within the example app needed to be adjusted. PR is here: eclipsesource/jsonforms2-website#114

@TheZoker TheZoker changed the title Fix categorization example to show nationality Enhance categorization example Jul 9, 2020
sdirix
sdirix approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@sdirix
Copy link
Member

sdirix commented Jul 10, 2020

Saw that the nationality control was again missing ;)

@sdirix sdirix merged commit d205f2c into eclipsesource:master Jul 10, 2020
@TheZoker TheZoker deleted the fix-categorization-example branch July 10, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Categorization example missing Field
3 participants
@TheZoker @coveralls @sdirix