Skip to content

hot fixes evaluation package + earthkit support #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 28, 2025
+7 −720
Merged

hot fixes evaluation package + earthkit support #1377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0e44edd
remove duplicate export_inference accidentally added by 1184
iluise Nov 28, 2025
7d94daa
Restore file deleted in previous commit
iluise Nov 28, 2025
667f951
fix integration test
iluise Nov 28, 2025
8cfb1de
Merge branch 'develop' into iluise/earthkit-support
iluise Nov 28, 2025
42b43c7
implement review comment
iluise Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions integration_tests/small1_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
import os
import shutil
from pathlib import Path

import omegaconf
import pytest

Expand Down Expand Up @@ -135,7 +134,7 @@ def evaluate_results(run_id):
}
)
# Not passing the mlflow client for tests.
evaluate_from_config(cfg, None)
evaluate_from_config(cfg, None, None )


def load_metrics(run_id):
Expand Down
6 changes: 5 additions & 1 deletion packages/evaluate/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ dependencies = [
"plotly>=6.2.0",
"weathergen-common",
"weathergen-metrics",
"eccodes==2.44.0",
Copy link
Collaborator

@tjhunter tjhunter Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that does not look like a hot fix, is this what you want?

"eccodeslib==2.44.0.7",
"eckitlib==1.32.3.7",
"earthkit-data==0.18.2"
]

[dependency-groups]
Expand All @@ -25,7 +29,7 @@ dev = [

[project.scripts]
evaluation = "weathergen.evaluate.run_evaluation:evaluate"
export = "weathergen.evaluate.export_inference:export"
export = "weathergen.evaluate.export.export_inference:export"

# The linting configuration
[tool.ruff]
Expand Down
2 changes: 1 addition & 1 deletion packages/evaluate/src/weathergen/evaluate/export/cf_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def scale_data(self, data: xr.DataArray, var_short: str) -> xr.DataArray:
Scaled data array.
"""
var_config = self.mapping.get(var_short, {})
raw = var_config.get("scale_factor", 1.0)
raw = var_config.get("scale_factor", "1.0")
parts = raw.split("/")
scale_factor = float(parts[0]) / float(parts[1]) if len(parts) == 2 else float(parts[0])

Expand Down
Loading