Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted files fail on CF-Conventions checkers. #36

Closed
alexamici opened this Issue Dec 5, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@alexamici
Copy link
Collaborator

commented Dec 5, 2018

Using the Reading University on-line checker on current master we fail in an embarrassing way: WARN: (2.6.1): No 'Conventions' attribute present 馃槥.

Including some level of compliance checking in unit tests would be ideal.

@alexamici alexamici self-assigned this Dec 5, 2018

alexamici added a commit that referenced this issue Dec 5, 2018

@alexamici alexamici removed the bug label Dec 5, 2018

alexamici added a commit that referenced this issue Dec 6, 2018

alexamici added a commit that referenced this issue Dec 6, 2018

@alexamici alexamici added bug and removed enhancement labels Dec 6, 2018

@alexamici

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 6, 2018

Converting to netCDF via xarray both with and without cf2cdm conversion now result in a file complying to CF conventions in all tested cases according to on-line checkers:

>>> ds = xr.open_dataset('file.grib', engine='cfgrib')
>>> ds.to_netcdf('file.nc')
>>> cf2cdm.translate_coords(ds, coord_model=cf2cdm.CDS).to_netcdf('file_cdm.nc')

A more comprehensive compliance testing is left to another issue.

@alexamici alexamici closed this Dec 6, 2018

@alexamici alexamici changed the title Add (automatic?) testing against a CF-Conventions checker. Converted files fail on CF-Conventions checkers. Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.