Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBP-4380: update startup of vagrant container #2

Merged
merged 15 commits into from Dec 9, 2019

Conversation

ioncache
Copy link

@ioncache ioncache commented Dec 4, 2019

No description provided.

kong Outdated
../kong
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in your local folder, do you have a submodules folder in the sb-kong-vagrant repo?

this symlink wouldn't work the way it is, as the repo doesn't have that folder, and the kong submodule is part of the smartbuildings-public-api repo

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might make more sense for kong to be a submodule of the vagrant repo instead

@ioncache ioncache merged commit 214b6e4 into master Dec 9, 2019
@ioncache ioncache deleted the SBP-4380-update-vagrant branch December 9, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant