Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace `stop()` with `skip()` so that other plugins won't break #469

Merged
merged 1 commit into from Jun 12, 2019

Conversation

Projects
None yet
2 participants
@sodatea
Copy link
Contributor

commented Jun 12, 2019

fixes #467

path.skip() skips traversing the children of the current path.
path.stop() stops traversal entirely.

So by using stop(), it may stop the execution of other babel plugins on
this file. In this case, it's proposal-decorators that failed to run.

fix: replace stop() with skip() so that other plugins won't break
fixes #467

`path.skip()` skips traversing the children of the current path.
`path.stop()` stops traversal entirely.

So by using `stop()`, it may stop execution of other babel plugins on
this file. In this case, it's `proposal-decorators` that failed to run.
@codecov

This comment has been minimized.

Copy link

commented Jun 12, 2019

Codecov Report

Merging #469 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #469   +/-   ##
=======================================
  Coverage   63.98%   63.98%           
=======================================
  Files         122      122           
  Lines        3324     3324           
  Branches      609      609           
=======================================
  Hits         2127     2127           
  Misses        980      980           
  Partials      217      217

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13079ca...d7dc39b. Read the comment docs.

@Justineo Justineo merged commit ac6dc06 into ecomfe:dev Jun 12, 2019

5 of 8 checks passed

Header rules - veui No header rules processed
Details
Pages changed - veui All files already uploaded
Details
Redirect rules - veui No redirect rules processed
Details
Mixed content - veui No mixed content detected
Details
ci/circleci: build Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 13079ca...d7dc39b
Details
codecov/project 63.98% remains the same compared to 13079ca
Details
netlify/veui/deploy-preview Deploy preview ready!
Details
@Justineo

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

Thanks @sodatea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.