Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gradient): #898 has bug about safe checkingand breaks all gradients #919

merged 1 commit into from
Jun 7, 2022


Copy link

@Ovilia Ovilia commented Jun 7, 2022

#898 tries to fix the problem of invalid input with gradients but it seems to get wrong results when checking if a number is safe. It caused all gradients to break down in Apache ECharts.

I also tested with the case of apache/echarts#16649 and #898 's fixing didn't work but after this PR's fixing it works.

@Ovilia Ovilia merged commit f1085eb into master Jun 7, 2022
@Ovilia Ovilia deleted the fix-gradient branch June 7, 2022 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants