-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new API source using the giantbomb.com API #3
Conversation
I love this idea. So. Great. |
import requests | ||
import logging | ||
import tablib | ||
import urllib2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you electing to use urllib2 for one object (line 62) while you could use requests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requests supports gzipped content by default with makes chunked downloading a bit of a mess. But an updated version will now use requests for consistency sake :-)
Now with 50% more hand-holding :-) |
These comments are great!! On Sun, Mar 3, 2013 at 8:21 AM, Horst Gutmann notifications@github.comwrote:
|
Okay - for your review, let me know your thoughts on how the tutorial reads: https://gist.github.com/econchick/29a6a892a54c743f3268 :) |
Manually merged! Still working on editing/fine-tuning the actual tutorial part. :) |
Selecting a random quote more elegantly
This one uses the Giantbomb.com API to fetch platform release dates and original prices and puts them into perspective with Federal Reserve CPI data (to calculate USD inflation), matplotlib (to generate to generate an output graph) and tablib (to generate a CSV file).