Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative to OpenSSL for md5 #32

Closed
chuckatkins opened this issue Oct 21, 2020 · 2 comments
Closed

Alternative to OpenSSL for md5 #32

chuckatkins opened this issue Oct 21, 2020 · 2 comments

Comments

@chuckatkins
Copy link
Contributor

Currently you're using the libcrypto from OpenSSL for MD5 hashing of files when computing checksums. Since the only use of OpenSSL is for MD5, it's a pretty heavyweight dependency for just that. Would you be open to a PR that brought in a different MD5 implementation in order to reduce the dependency footprint?

@bnicolae
Copy link
Contributor

Chuck, sure in fact we don't even mind switching from MD5 to a different checksum as long as it works reasonably well to detect corruption of data.

@bnicolae
Copy link
Contributor

bnicolae commented Feb 9, 2021

@chuckatkins: since we did not receive a pull request in a long time, I am assuming this is not an issue any longer. Feel free to reopen it if needed.

@bnicolae bnicolae closed this as completed Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants