Update requirements.txt with latest versions #8

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@yuvadm

yuvadm commented Apr 3, 2013

requirements.txt should explicitly mention dependency versions.
Latest and greatest seem to work just fine.

Also, south was missing.

@ecprice

This comment has been minimized.

Show comment
Hide comment
@ecprice

ecprice Jun 12, 2013

Owner

I've added the django-south requirement.

I'm not sure it makes sense to require specific versions of libraries, though; the code should work for a variety of versions, and I don't want to force unnecessary upgrades/downgrades. If you see any versions that don't work, let me know.

Owner

ecprice commented Jun 12, 2013

I've added the django-south requirement.

I'm not sure it makes sense to require specific versions of libraries, though; the code should work for a variety of versions, and I don't want to force unnecessary upgrades/downgrades. If you see any versions that don't work, let me know.

@ecprice ecprice closed this Jun 12, 2013

@yuvadm

This comment has been minimized.

Show comment
Hide comment
@yuvadm

yuvadm Jun 12, 2013

@ecprice it is a common convention to have pip freeze > requirements.txt (which includes hard versions) to ensure that any future changes do not break compatibility. Upgrades/downgrades are moot if using proper virtual environments.

On a side note, the rest of the project is very much out of date and out of touch with Pythonic idioms and conventions, especially with regards to directory structure and project settings and environment.

I'd be happy to help out in standardizing this repository to bring it up to date.

yuvadm commented Jun 12, 2013

@ecprice it is a common convention to have pip freeze > requirements.txt (which includes hard versions) to ensure that any future changes do not break compatibility. Upgrades/downgrades are moot if using proper virtual environments.

On a side note, the rest of the project is very much out of date and out of touch with Pythonic idioms and conventions, especially with regards to directory structure and project settings and environment.

I'd be happy to help out in standardizing this repository to bring it up to date.

@ecprice

This comment has been minimized.

Show comment
Hide comment
@ecprice

ecprice Jun 12, 2013

Owner

Yeah, I have no idea what's standard here. What's a good reference for
modern conventions on this stuff?

On Wed, Jun 12, 2013 at 5:45 PM, Yuval Adam notifications@github.comwrote:

@ecprice https://github.com/ecprice it is a common convention to have pip
freeze > requirements.txt to ensure that any future changes do not break
compatibility. Upgrades/downgrades are moot if using proper virtual
environments.

On a side note, the rest of the project is very much out of date and out
of touch with Pythonic idioms and conventions, especially with regards to
directory structure and project settings and environment.

I'd be happy to help out in standardizing this repository to bring it up
to date.


Reply to this email directly or view it on GitHubhttps://github.com/ecprice/newsdiffs/pull/8#issuecomment-19357814
.

Owner

ecprice commented Jun 12, 2013

Yeah, I have no idea what's standard here. What's a good reference for
modern conventions on this stuff?

On Wed, Jun 12, 2013 at 5:45 PM, Yuval Adam notifications@github.comwrote:

@ecprice https://github.com/ecprice it is a common convention to have pip
freeze > requirements.txt to ensure that any future changes do not break
compatibility. Upgrades/downgrades are moot if using proper virtual
environments.

On a side note, the rest of the project is very much out of date and out
of touch with Pythonic idioms and conventions, especially with regards to
directory structure and project settings and environment.

I'd be happy to help out in standardizing this repository to bring it up
to date.


Reply to this email directly or view it on GitHubhttps://github.com/ecprice/newsdiffs/pull/8#issuecomment-19357814
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment