Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase compatibility with Rollbar API #1

Merged
merged 3 commits into from Dec 27, 2019
Merged

Conversation

ecton
Copy link
Owner

@ecton ecton commented Dec 27, 2019

First, I removed code field as per RoxasShadow#13. Based on the Rollbar engineer's comment, since we don't have access to the source code, we should be omitting this value.

However, I was still having grouping issues. In reading through the errors and looking at the settings in Rollbar, i determined that the exception.class field being set to the Thread's name is what was causing the grouping errors.

Unfortunately, typename is deprecated because a new feature was added to rust 1.38 giving an official way to get the name of a type. I added the usage of this new feature, but that means that if this is merged, there's a new requirement on Rust 1.38 and it appears there's not a way to currently specify that in the Cargo.toml.

I'll be creating an MR back to the main branch with these changes, but I'll also publish a tag if someone wants to use a git ref to refer to my repo.

@ecton
Copy link
Owner Author

ecton commented Dec 27, 2019

Unfortunately I can't get Github to realize the first two commits were already on my master. The only set of changes for this is: f0d4585

I unfortunately based this branch off of the previous fix I made and didn't push my master before creating the MR.

@ecton ecton merged commit 5240e90 into master Dec 27, 2019
@ecton ecton deleted the increaseCompatibility branch Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant