Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

fix summary line #70

Closed
wants to merge 1 commit into from

2 participants

@tarsius

also is the #! still required in ecukes.el? My tool finds the summary on the second line too but lm-summary from built-in lisp-mnt.el does not.

@rejeep
Owner

Hi, I will not merge this right now due to pull request #69 (#69), which changes the file structure a bit. I will leave this open as a reminder to fix it once the pull request have been merged.

@tarsius

Okay, thanks.

@tarsius

Could you please merge this now? If this causes a merge conflict later on, then it will be one that is very easy to resolve :-)

@rejeep
Owner

Really sorry about the delay...

I'm planning to work on the v0.3 milestone this weekend and this is a part of that.

@tarsius

oki :-)

@rejeep
Owner

Hi,

I'm currently working on releasing v0.3 (branch here https://github.com/rejeep/ecukes/tree/v0.3). There are a lot of changes compared to this one. Can you please take a look at it and tell me if you'd like me to change any header information there?

Thanks

@tarsius

I would suggest that for ecukes.el you copy the header from the master branch and then replace the "See README" with the content of that file.

@rejeep
Owner

Does your script automatically pick up what file to parse or do you have to specify it manually?

@tarsius

For a package foo it uses the first file named foo.el that it finds. This can be overwritten though. You are going to suggest that I should parse ecukes instead of ecukes.el, right? :-)

@rejeep
Owner

You got me! :)

I think it would be better if it's not a big issue for you...

It doesn't make sense to parse ecukes.el since it's not the "init file". The file ecukes is the init file and depending on if Ecukes runs from terminal or from inside Emacs, ecukes-term.el or ecukes.el runs resp.

@rejeep rejeep closed this
@tarsius

I have reverted to auto-detect ecukes.el as "main library" as I cannot extract anything from ecukes because it is a shell script. This way I can at least extract the summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 29, 2012
  1. @tarsius

    fix summary line

    tarsius authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  ecukes.el
View
2  ecukes.el
@@ -1,5 +1,5 @@
#!/usr/bin/env emacs --script
-;;; ecukes --- Cucumber for Emacs
+;;; ecukes.el --- Cucumber for Emacs
;; Copyright (C) 2010 Johan Andersson
Something went wrong with that request. Please try again.