Cannot resize iterm2 in thirds #190

Closed
giannic opened this Issue Feb 21, 2014 · 15 comments

Projects

None yet

9 participants

@giannic

Happens with any key combination on OSX Mavericks 10.9.1. Same assigned key combination works to resize other applications into thirds.

@kevinhughes27

I can confirm this happens for me as well

@espinet

This is a bummer.

@drpowell

I had the same problem. This seems to be caused by the BlacklistedWindowRects code in 'moveWindowRect:'

The BlacklistedWindowRects are persisted in the user preferences, so I was able to hack around this by doing:
defaults delete com.divisiblebyzero.Spectacle

Obviously not a proper fix, but I'm not sure I understand the point of BlacklistedWindowRects

@kevinhughes27

@drpowell I tried running defaults delete com.divisiblebyzero.Spectacle in iterm2 but I still can't resize to one thirds

@drpowell

@pickle27 Did you first stop spectacle when you cleared the defaults?

Alternatively, you could try this patch to disable the BlacklistedWindowRects code:

diff --git a/SpectacleWindowPositionManager.m b/SpectacleWindowPositionManager.m
index 31cd9c5..5e690ac 100644
--- a/SpectacleWindowPositionManager.m
+++ b/SpectacleWindowPositionManager.m
@@ -214,7 +214,7 @@
     NSString *frontMostApplicationName = ZKAccessibilityElement.frontMostApplicationName;
     NSString *blacklistedWindowRect = BlacklistedWindowRect(frontMostApplicationName, windowRect);

-    if ([_blacklistedWindowRects containsObject: blacklistedWindowRect] || [_blacklistedApplications containsObject: fr
+    if ([_blacklistedApplications containsObject: frontMostApplicationName]) {
         NSBeep();
@kevinhughes27

hmm I did not. I'll try again thanks!

@kevinhughes27

still nothing, haven't tried the patch though

@drpowell

Hmm, bummer. For me, the problem is definitely the blacklisting of rects, the patch fixes it - although presumably disables some useful functionality. Hopefully someone with more knowledge of the source can suggest a proper fix.

@mfournierca

I'm experiencing this issue as well. Spectacle can resize the iTerm window to full screen, half screen, top half and bottom half, but not thirds.

iTerm2 build 1.0.0.20130622
Spectacle 0.8.4 (13)
OSX Mavericks 10.9.2

I really like spectacle, keep up the good work!

EDIT: This issue only occurs on my external monitor, an Acer P221W. It does not occur on the MacBook screen.

@nonagonal

Same here, Spectacle can't seem to resize Terminal to thirds (but moving between monitors, halfs, etc works fine, same keyboard shortcut works to do other things).

OSX Mavericks 10.9.2.

@nonagonal

Works well for me now in Spectacle 0.8.5. Thanks!

@eczarny eczarny closed this Jun 22, 2014
@betz

Just as a memo for the next guy:

If you happen to have the problem that iterm2 won't respond at all to spectacle, reboot osx.
I just installed iterm2 and spectacle on a fresh OSX, and got this issue.
After a reboot, everything works as expected.

@kevinhughes27

For me it works going to the left now but not to the right, and I put my terminal on the right :(

@andressrg

I'm experiencing the same issue as @pickle27
Works to the left, not to the right.

@giannic

This seems to be to still be a problem. Maybe should we reopened for tracking. I don't think reboots are working for me. I have mine bound to alt-leftarrow/rightarrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment