fixed a few warnings

eczarny · May 16, 2011 · a11816d · a11816d
1 parent 5439006
commit a11816d
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 8 deletions.
diff --git a/XMLRPCConnection.m b/XMLRPCConnection.m
@@ -51,7 +51,8 @@ - (void)connectionDidFinishLoading: (NSURLConnection *)connection;
 @implementation XMLRPCConnection
 
 - (id)initWithXMLRPCRequest: (XMLRPCRequest *)request delegate: (id<XMLRPCConnectionDelegate>)delegate manager: (XMLRPCConnectionManager *)manager {
-    if (self = [super init]) {
+    self = [super init];
+    if (self) {
         myManager = [manager retain];
         myRequest = [request retain];
         myIdentifier = [[NSString stringByGeneratingUUID] retain];

diff --git a/XMLRPCConnectionManager.m b/XMLRPCConnectionManager.m
@@ -29,7 +29,8 @@ @implementation XMLRPCConnectionManager
 static XMLRPCConnectionManager *sharedInstance = nil;
 
 - (id)init {
-    if (self = [super init]) {
+    self = [super init];
+    if (self) {
         myConnections = [[NSMutableDictionary alloc] init];
     }
 
@@ -55,7 +56,7 @@ + (id)allocWithZone: (NSZone *)zone {
 + (XMLRPCConnectionManager *)sharedManager {
     @synchronized(self) {
         if (!sharedInstance) {
-            [[self alloc] init];
+            sharedInstance = [[self alloc] init];
         }
     }
 

diff --git a/XMLRPCEncoder.m b/XMLRPCEncoder.m
@@ -60,7 +60,8 @@ - (NSString *)encodeData: (NSData *)data;
 @implementation XMLRPCEncoder
 
 - (id)init {
-    if (self = [super init]) {
+    self = [super init];
+    if (self) {
         myMethod = [[NSString alloc] init];
         myParameters = [[NSArray alloc] init];
     }
@@ -81,7 +82,7 @@ - (NSString *)encode {
         NSEnumerator *enumerator = [myParameters objectEnumerator];
         id parameter = nil;
 
-        while (parameter = [enumerator nextObject]) {
+        while ((parameter = [enumerator nextObject])) {
             [buffer appendString: @"<param>"];
             [buffer appendString: [self encodeObject: parameter]];
             [buffer appendString: @"</param>"];

diff --git a/XMLRPCEventBasedParserDelegate.m b/XMLRPCEventBasedParserDelegate.m
@@ -56,7 +56,8 @@ - (NSData *)parseData: (NSString *)value;
 @implementation XMLRPCEventBasedParserDelegate
 
 - (id)initWithParent: (XMLRPCEventBasedParserDelegate *)parent {
-    if (self = [super init]) {
+    self = [super init];
+    if (self) {
         myParent = parent;
         myChildren = [[NSMutableArray alloc] initWithCapacity: 1];
         myElementType = XMLRPCElementTypeString;

diff --git a/XMLRPCRequest.m b/XMLRPCRequest.m
@@ -26,7 +26,8 @@
 @implementation XMLRPCRequest
 
 - (id)initWithURL: (NSURL *)URL {
-    if (self = [super init]) {
+    self = [super init];
+    if (self) {
         if (URL) {
             myRequest = [[NSMutableURLRequest alloc] initWithURL: URL];
         } else {

diff --git a/XMLRPCResponse.m b/XMLRPCResponse.m
@@ -30,7 +30,8 @@ - (id)initWithData: (NSData *)data {
         return nil;
     }
 
-    if (self = [super init]) {
+    self = [super init];
+    if (self) {
         XMLRPCEventBasedParser *parser = [[XMLRPCEventBasedParser alloc] initWithData: data];
 
         if (!parser) {