Permalink
Browse files

Strip issue id when adding a relation.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9384 e93f8b46-1217-0410-a6f0-8f06a7374b81
  • Loading branch information...
1 parent 04e7b18 commit 12b71ebc8e9de6ebb8e1bdf96928422f8a63bd81 @jplang jplang committed Apr 11, 2012
@@ -42,7 +42,7 @@ def show
def create
@relation = IssueRelation.new(params[:relation])
@relation.issue_from = @issue
- if params[:relation] && m = params[:relation][:issue_to_id].to_s.match(/^#?(\d+)$/)
+ if params[:relation] && m = params[:relation][:issue_to_id].to_s.strip.match(/^#?(\d+)$/)
@relation.issue_to = Issue.visible.find_by_id(m[1].to_i)
end
saved = @relation.save
@@ -71,6 +71,16 @@ def test_create_should_accept_id_with_hash
end
end
+ def test_create_should_strip_id
+ assert_difference 'IssueRelation.count' do
+ @request.session[:user_id] = 3
+ post :create, :issue_id => 1,
+ :relation => {:issue_to_id => ' 2 ', :relation_type => 'relates', :delay => ''}
+ end
+ relation = IssueRelation.first(:order => 'id DESC')
+ assert_equal 2, relation.issue_to_id
+ end
+
def test_create_should_not_break_with_non_numerical_id
assert_no_difference 'IssueRelation.count' do
assert_nothing_raised do

0 comments on commit 12b71eb

Please sign in to comment.