From d0a0366fb7c87d0322280fb1d3bf02acc6fc03a3 Mon Sep 17 00:00:00 2001 From: Ed Carroll Date: Fri, 11 Aug 2017 06:15:26 +0100 Subject: [PATCH] feat(popup): Renamed popupText to suiPopup to reduce markup --- demo/src/app/components/api/api.component.html | 6 +++--- demo/src/app/components/example/example.component.html | 2 +- demo/src/app/pages/modules/popup/popup.page.ts | 8 ++++---- src/modules/popup/directives/popup.directive.ts | 2 +- 4 files changed, 9 insertions(+), 9 deletions(-) diff --git a/demo/src/app/components/api/api.component.html b/demo/src/app/components/api/api.component.html index 4b85ce192..5b24f495f 100644 --- a/demo/src/app/components/api/api.component.html +++ b/demo/src/app/components/api/api.component.html @@ -11,8 +11,8 @@

{{ property.name }}  -
{{ property.type }}
-
{{ property.defaultValue }}
+
{{ property.type }}
+
{{ property.defaultValue }}
required
@@ -30,7 +30,7 @@

{{ event.name }}  -
{{ event.type }}
+
{{ event.type }}
diff --git a/demo/src/app/components/example/example.component.html b/demo/src/app/components/example/example.component.html index a1152d3f2..2e69586cb 100644 --- a/demo/src/app/components/example/example.component.html +++ b/demo/src/app/components/example/example.component.html @@ -1,7 +1,7 @@
- +
diff --git a/demo/src/app/pages/modules/popup/popup.page.ts b/demo/src/app/pages/modules/popup/popup.page.ts index 509d0732e..293f19d55 100644 --- a/demo/src/app/pages/modules/popup/popup.page.ts +++ b/demo/src/app/pages/modules/popup/popup.page.ts @@ -3,7 +3,7 @@ import { ApiDefinition } from "../../../components/api/api.component"; import { SuiPopupConfig } from "ng2-semantic-ui"; const exampleStandardTemplate = ` - `; @@ -21,7 +21,7 @@ const exampleTemplateTemplate = ` `; const examplePlacementTemplate = ` -
+
Positioning
@@ -41,7 +41,7 @@ export class PopupPage { selector: "[suiPopup]", properties: [ { - name: "popupText", + name: "suiPopup", type: "string", description: "Sets the text within the popup." }, @@ -130,7 +130,7 @@ export class PopupPage { public position:string = "bottom right"; public manualPopupMarkup:string = ` -
+
diff --git a/src/modules/popup/directives/popup.directive.ts b/src/modules/popup/directives/popup.directive.ts index f89e76793..427957a60 100644 --- a/src/modules/popup/directives/popup.directive.ts +++ b/src/modules/popup/directives/popup.directive.ts @@ -20,7 +20,7 @@ export class SuiPopupDirective extends SuiPopupController { this.popup.config.header = header; } - @Input() + @Input("suiPopup") public set popupText(text:string) { this.popup.config.text = text; }