Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Named argument in cpp call to Sys.setenv() #95

Merged
merged 2 commits into from Jun 26, 2019

Conversation

@christophsax
Copy link
Contributor

commented Jun 25, 2019

  • fixes #94
  • also mentions all arguments in anytime_cpp
@codecov

This comment has been minimized.

Copy link

commented Jun 25, 2019

Codecov Report

Merging #95 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #95   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         236    236           
=====================================
  Hits          236    236
Impacted Files Coverage Δ
src/anytime.cpp 100% <ø> (ø) ⬆️
R/anytime.R 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98f6bdb...5d912ed. Read the comment docs.

Show resolved Hide resolved R/anytime.R
Show resolved Hide resolved src/anytime.cpp

@eddelbuettel eddelbuettel merged commit b86869f into eddelbuettel:master Jun 26, 2019

3 checks passed

codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to 98f6bdb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@christophsax christophsax referenced this pull request Jun 26, 2019

Closed

Errors on Windows #154

@christophsax

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

Thanks for the light-speed support!

Any plans that this goes to CRAN soon? My win ERRORS in tsbox are coming from this one (the Solaris one is unrelated): https://cran.r-project.org/web/checks/check_results_tsbox.html

@eddelbuettel

This comment has been minimized.

Copy link
Owner

commented Jun 26, 2019

Yes. Was thinking within days as Solaris blows up on CRAN for me (which I "addressed" by suppressing tests).

I was wondering if I could lean on you for one more quick test. I also suppressed a lot of Windows tests, maybe too many. With tinytest, you can very easily run individual test files via Rscript -e 'tinytest::run_test_file("nameofile.R")'. Could you open the files in inst/tinytest/ that grep for isWindows and see if some of the tests could in fact be reactivated? I could test it too, but only via rhub and takes a few cycles...

@christophsax

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

Yes, will do. But only have time in in a few hours.

@eddelbuettel

This comment has been minimized.

Copy link
Owner

commented Jun 26, 2019

Thanks so much -- that works for me. I'll pick it up in 12 hours after work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.