Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests that pass on windows, too #97

Merged
merged 2 commits into from Jun 27, 2019

Conversation

@christophsax
Copy link
Contributor

commented Jun 26, 2019

No description provided.

tests that pass on windows, too
> tinytest::test_all()

Running test_all_formats.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_all_formats.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_all_formats.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_all_formats.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_all_formats.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_all_formats.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_all_formats.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_all_formats.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_all_formats.R (01|�[0;32m01�[0m|�[0;31m00�[0m)
Running test_all_formats.R (02|�[0;32m02�[0m|�[0;31m00�[0m)
Running test_all_formats.R (03|�[0;32m03�[0m|�[0;31m00�[0m)

Running test_assertions.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_assertions.R (01|�[0;32m01�[0m|�[0;31m00�[0m)
Running test_assertions.R (02|�[0;32m02�[0m|�[0;31m00�[0m)

Running test_bulk.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_bulk.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_bulk.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_bulk.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_bulk.R (00|�[0;32m00�[0m|�[0;31m00�[0m)

Running test_gh_issue_12.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_gh_issue_12.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_gh_issue_12.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_gh_issue_12.R (01|�[0;32m01�[0m|�[0;31m00�[0m)
Running test_gh_issue_12.R (02|�[0;32m02�[0m|�[0;31m00�[0m)

Running test_gh_issue_33.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_gh_issue_33.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_gh_issue_33.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_gh_issue_33.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_gh_issue_33.R (01|�[0;32m01�[0m|�[0;31m00�[0m)
Running test_gh_issue_33.R (02|�[0;32m02�[0m|�[0;31m00�[0m)

Running test_gh_issue_5.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_gh_issue_5.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_gh_issue_5.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_gh_issue_5.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_gh_issue_5.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_gh_issue_5.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_gh_issue_5.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_gh_issue_5.R (01|�[0;32m01�[0m|�[0;31m00�[0m)
Running test_gh_issue_5.R (02|�[0;32m02�[0m|�[0;31m00�[0m)
Running test_gh_issue_5.R (02|�[0;32m02�[0m|�[0;31m00�[0m)
Running test_gh_issue_5.R (02|�[0;32m02�[0m|�[0;31m00�[0m)
Running test_gh_issue_5.R (03|�[0;32m03�[0m|�[0;31m00�[0m)
Running test_gh_issue_5.R (04|�[0;32m04�[0m|�[0;31m00�[0m)

Running test_gh_issue_56.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_gh_issue_56.R (01|�[0;32m01�[0m|�[0;31m00�[0m)
Running test_gh_issue_56.R (02|�[0;32m02�[0m|�[0;31m00�[0m)
Running test_gh_issue_56.R (03|�[0;32m03�[0m|�[0;31m00�[0m)
Running test_gh_issue_56.R (07|�[0;32m07�[0m|�[0;31m00�[0m)

Running test_gh_issue_84.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_gh_issue_84.R (00|�[0;32m00�[0m|�[0;31m00�[0m)

Running test_gh_issues_36_51.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_gh_issues_36_51.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_gh_issues_36_51.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_gh_issues_36_51.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_gh_issues_36_51.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_gh_issues_36_51.R (00|�[0;32m00�[0m|�[0;31m00�[0m)

Running test_r_format.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_r_format.R (00|�[0;32m00�[0m|�[0;31m00�[0m)

Running test_simple.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_simple.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_simple.R (15|�[0;32m15�[0m|�[0;31m00�[0m)

Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_utilities.R (01|�[0;32m01�[0m|�[0;31m00�[0m)
Running test_utilities.R (02|�[0;32m02�[0m|�[0;31m00�[0m)
Running test_utilities.R (02|�[0;32m02�[0m|�[0;31m00�[0m)
Running test_utilities.R (03|�[0;32m03�[0m|�[0;31m00�[0m)

Running test_validate.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_validate.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_validate.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
Running test_validate.R (00|�[0;32m00�[0m|�[0;31m00�[0m)
All ok (38 results)
@@ -9,7 +9,7 @@ expect_true(is.finite(anytime(20170101L)))
expect_true(is.finite(anydate(20170101L)))

## overflows on Windows, sadly
if (.Platform$OS.type != "windows") {
if (.Platform$OS.type != "windows" | TRUE) {

This comment has been minimized.

Copy link
@christophsax

christophsax Jun 26, 2019

Author Contributor

I can remove the if() and indentation if you want.

@eddelbuettel

This comment has been minimized.

Copy link
Owner

commented Jun 26, 2019

Removing the | TRUE and reindenting would be nice. I could do it too.

I checked on Travis, it only failed because CRAN is currently down (as I heard 2nd-hand). We may want to wait a moment til it is back (if it comes back) to re-run the Travis test.

@codecov

This comment has been minimized.

Copy link

commented Jun 27, 2019

Codecov Report

Merging #97 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #97   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         236    236           
=====================================
  Hits          236    236

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b86869f...4c8de3c. Read the comment docs.

@eddelbuettel

This comment has been minimized.

Copy link
Owner

commented Jun 27, 2019

I restarted the Travis job now that we have CRAN back. All good.

@eddelbuettel eddelbuettel merged commit fd9612e into eddelbuettel:master Jun 27, 2019

3 checks passed

codecov/patch Coverage not affected when comparing b86869f...4c8de3c
Details
codecov/project 100% remains the same compared to b86869f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.