tests that pass on windows, too #97

christophsax · 2019-06-26T18:35:34Z

No description provided.

> tinytest::test_all() Running test_all_formats.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_all_formats.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_all_formats.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_all_formats.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_all_formats.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_all_formats.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_all_formats.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_all_formats.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_all_formats.R (01|�[0;32m01�[0m|�[0;31m00�[0m) Running test_all_formats.R (02|�[0;32m02�[0m|�[0;31m00�[0m) Running test_all_formats.R (03|�[0;32m03�[0m|�[0;31m00�[0m) Running test_assertions.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_assertions.R (01|�[0;32m01�[0m|�[0;31m00�[0m) Running test_assertions.R (02|�[0;32m02�[0m|�[0;31m00�[0m) Running test_bulk.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_bulk.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_bulk.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_bulk.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_bulk.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_gh_issue_12.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_gh_issue_12.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_gh_issue_12.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_gh_issue_12.R (01|�[0;32m01�[0m|�[0;31m00�[0m) Running test_gh_issue_12.R (02|�[0;32m02�[0m|�[0;31m00�[0m) Running test_gh_issue_33.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_gh_issue_33.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_gh_issue_33.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_gh_issue_33.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_gh_issue_33.R (01|�[0;32m01�[0m|�[0;31m00�[0m) Running test_gh_issue_33.R (02|�[0;32m02�[0m|�[0;31m00�[0m) Running test_gh_issue_5.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_gh_issue_5.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_gh_issue_5.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_gh_issue_5.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_gh_issue_5.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_gh_issue_5.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_gh_issue_5.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_gh_issue_5.R (01|�[0;32m01�[0m|�[0;31m00�[0m) Running test_gh_issue_5.R (02|�[0;32m02�[0m|�[0;31m00�[0m) Running test_gh_issue_5.R (02|�[0;32m02�[0m|�[0;31m00�[0m) Running test_gh_issue_5.R (02|�[0;32m02�[0m|�[0;31m00�[0m) Running test_gh_issue_5.R (03|�[0;32m03�[0m|�[0;31m00�[0m) Running test_gh_issue_5.R (04|�[0;32m04�[0m|�[0;31m00�[0m) Running test_gh_issue_56.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_gh_issue_56.R (01|�[0;32m01�[0m|�[0;31m00�[0m) Running test_gh_issue_56.R (02|�[0;32m02�[0m|�[0;31m00�[0m) Running test_gh_issue_56.R (03|�[0;32m03�[0m|�[0;31m00�[0m) Running test_gh_issue_56.R (07|�[0;32m07�[0m|�[0;31m00�[0m) Running test_gh_issue_84.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_gh_issue_84.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_gh_issues_36_51.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_gh_issues_36_51.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_gh_issues_36_51.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_gh_issues_36_51.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_gh_issues_36_51.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_gh_issues_36_51.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_r_format.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_r_format.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_simple.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_simple.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_simple.R (15|�[0;32m15�[0m|�[0;31m00�[0m) Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_utilities.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_utilities.R (01|�[0;32m01�[0m|�[0;31m00�[0m) Running test_utilities.R (02|�[0;32m02�[0m|�[0;31m00�[0m) Running test_utilities.R (02|�[0;32m02�[0m|�[0;31m00�[0m) Running test_utilities.R (03|�[0;32m03�[0m|�[0;31m00�[0m) Running test_validate.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_validate.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_validate.R (00|�[0;32m00�[0m|�[0;31m00�[0m) Running test_validate.R (00|�[0;32m00�[0m|�[0;31m00�[0m) All ok (38 results)

christophsax · 2019-06-26T18:36:26Z

inst/tinytest/test_gh_issue_56.R

@@ -9,7 +9,7 @@ expect_true(is.finite(anytime(20170101L)))
 expect_true(is.finite(anydate(20170101L)))

 ## overflows on Windows, sadly
-if (.Platform$OS.type != "windows") {
+if (.Platform$OS.type != "windows" | TRUE) {


I can remove the if() and indentation if you want.

eddelbuettel · 2019-06-26T18:48:28Z

Removing the | TRUE and reindenting would be nice. I could do it too.

I checked on Travis, it only failed because CRAN is currently down (as I heard 2nd-hand). We may want to wait a moment til it is back (if it comes back) to re-run the Travis test.

codecov · 2019-06-27T11:07:44Z

Codecov Report

Merging #97 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #97   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         236    236           
=====================================
  Hits          236    236

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b86869f...4c8de3c. Read the comment docs.

eddelbuettel · 2019-06-27T11:22:51Z

I restarted the Travis job now that we have CRAN back. All good.

christophsax reviewed Jun 26, 2019

View changes

remove obsolete if() and reindent

Loading status checks…

4c8de3c

eddelbuettel mentioned this pull request Jun 26, 2019

TZ setting under Windows #96

Closed

eddelbuettel / anytime

tests that pass on windows, too #97

tests that pass on windows, too #97

christophsax commented Jun 26, 2019

This comment has been minimized.

eddelbuettel commented Jun 26, 2019

codecov bot commented Jun 27, 2019

eddelbuettel commented Jun 27, 2019

eddelbuettel / anytime

Join GitHub today

tests that pass on windows, too #97

tests that pass on windows, too #97

Conversation

christophsax commented Jun 26, 2019

This comment has been minimized.

christophsax Jun 26, 2019 Author Contributor

eddelbuettel commented Jun 26, 2019

codecov bot commented Jun 27, 2019

Codecov Report

eddelbuettel commented Jun 27, 2019

Essential cookies

Always active

Analytics cookies

christophsax Jun 26, 2019
Author Contributor