New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to asio 1.12.1 (for compatibility with OpenSSL 1.1.0) #2

Merged
merged 1 commit into from Sep 4, 2018

Conversation

Projects
None yet
2 participants
@jcheng5
Contributor

jcheng5 commented Sep 4, 2018

Hi Dirk,

My team has a new R package for WebSocket clients that depends on asioheaders. A user reported that it couldn't be installed on recent rocker images: rstudio/websocket#15

Here is the underlying asio issue: chriskohlhoff/asio#184

No problems reported with R CMD check --as-cran on iptools (both CRAN and GitHub versions), which is the only direct reverse dependency on CRAN.

Please let me know if you need any other information from me--thanks!

@jcheng5 jcheng5 referenced this pull request Sep 4, 2018

Merged

Update to websocketpp 0.8.1 #23

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Sep 4, 2018

Owner

That rocks.

I was actually going over dozens of repos of mine this weekend (for a benign Travis use upgrade) and also noticed the new Asio and planned to do this. Your PR makes it a lot easier :)

As you know, CRAN is currently closed so there is not way to rush this but I think I will push this as soon as they reopen. Would you need it / would it help if it were drat-able? I could push it into one of mine...

Owner

eddelbuettel commented Sep 4, 2018

That rocks.

I was actually going over dozens of repos of mine this weekend (for a benign Travis use upgrade) and also noticed the new Asio and planned to do this. Your PR makes it a lot easier :)

As you know, CRAN is currently closed so there is not way to rush this but I think I will push this as soon as they reopen. Would you need it / would it help if it were drat-able? I could push it into one of mine...

@eddelbuettel eddelbuettel merged commit 59dbd38 into eddelbuettel:master Sep 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jcheng5

This comment has been minimized.

Show comment
Hide comment
@jcheng5

jcheng5 Sep 4, 2018

Contributor

Thanks for merging! No need to drat, I don't think--and our stuff isn't on CRAN yet anyway, so if you submit next week or whenever that'd be fine with me.

Contributor

jcheng5 commented Sep 4, 2018

Thanks for merging! No need to drat, I don't think--and our stuff isn't on CRAN yet anyway, so if you submit next week or whenever that'd be fine with me.

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Sep 10, 2018

Owner

This is now on CRAN. Thanks again for the clean PR.

Owner

eddelbuettel commented Sep 10, 2018

This is now on CRAN. Thanks again for the clean PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment