New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing files under boost/align? #32

Closed
yixuan opened this Issue Nov 14, 2016 · 7 comments

Comments

Projects
None yet
2 participants
@yixuan

yixuan commented Nov 14, 2016

I noticed that in the align folder, some files are missing compared with the official Boost repository, see
eddelbuettle/bh and boostorg/align.

Is it intentional to reduce package size?

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Nov 14, 2016

Owner

Unintentional side effect from not officially including align. The files we have were "pulled in": See how we bcp over two sets of packages in this script.

Do you need the align library?

Owner

eddelbuettel commented Nov 14, 2016

Unintentional side effect from not officially including align. The files we have were "pulled in": See how we bcp over two sets of packages in this script.

Do you need the align library?

@yixuan

This comment has been minimized.

Show comment
Hide comment
@yixuan

yixuan Nov 14, 2016

I see. I have a package that is using a library replying on align, and that's why I noticed this difference. This package is just for my personal use, and I just need to link to the system boost headers. No worries.

yixuan commented Nov 14, 2016

I see. I have a package that is using a library replying on align, and that's why I noticed this difference. This package is just for my personal use, and I just need to link to the system boost headers. No worries.

@yixuan yixuan closed this Nov 14, 2016

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Nov 14, 2016

Owner

We could keep this open and add it next time ...

Owner

eddelbuettel commented Nov 14, 2016

We could keep this open and add it next time ...

@yixuan

This comment has been minimized.

Show comment
Hide comment
@yixuan

yixuan Nov 14, 2016

Great. I could reopen it when the next release of Boost arrives.

yixuan commented Nov 14, 2016

Great. I could reopen it when the next release of Boost arrives.

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Nov 14, 2016

Owner

Let's reopen now and leave it here so that neither one of us forgets. :)

Owner

eddelbuettel commented Nov 14, 2016

Let's reopen now and leave it here so that neither one of us forgets. :)

@yixuan

This comment has been minimized.

Show comment
Hide comment
@yixuan

yixuan Aug 13, 2017

Thanks! I almost forgot this issue. 😄

yixuan commented Aug 13, 2017

Thanks! I almost forgot this issue. 😄

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Aug 13, 2017

Owner

Sorry for the delay. Other packages kept me busy. Now waiting on one or two packages to make changes before this goes to CRAN.

Owner

eddelbuettel commented Aug 13, 2017

Sorry for the delay. Other packages kept me busy. Now waiting on one or two packages to make changes before this goes to CRAN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment