New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add Boost sort to BH #35

Closed
artemklevtsov opened this Issue Dec 16, 2016 · 9 comments

Comments

Projects
None yet
2 participants
@artemklevtsov

artemklevtsov commented Dec 16, 2016

Hi.
I can't found some boost headers in this package. Please tell me how can I use a missing headers in my package?
Now I install the boost headers in my OS. But I look for a way to do it without external system wide dependencies.

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Dec 16, 2016

Owner

See the DESCRIPTION of the package as well as the README of the repo; they both list a set of included Boost libraries in the BH.

Boost contains more libraries. We expanded BH over time -- see the NEWS.Rd (or ChangeLog or closed Issue tickets).

So to make it more concrete: what Boost library are you missing files from?

Owner

eddelbuettel commented Dec 16, 2016

See the DESCRIPTION of the package as well as the README of the repo; they both list a set of included Boost libraries in the BH.

Boost contains more libraries. We expanded BH over time -- see the NEWS.Rd (or ChangeLog or closed Issue tickets).

So to make it more concrete: what Boost library are you missing files from?

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel
Owner

eddelbuettel commented Dec 16, 2016

Is it this Boost sort library ?

@artemklevtsov

This comment has been minimized.

Show comment
Hide comment
@artemklevtsov

artemklevtsov Dec 16, 2016

Yes, it is sort library. spreadsort is too good to ignore it.

artemklevtsov commented Dec 16, 2016

Yes, it is sort library. spreadsort is too good to ignore it.

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Dec 16, 2016

Owner

Ok. I'll retitle this ticket and take it as a request to add sort as it seems to be header-only and suitable.

How soon would you need it? What others have done, eg rstan, is to augment in their sources beyond what we have in BH now, and it to point to it in your sources via an extra -I....

By the next release (in a few months) it will be included in BH. Does that work for you?

Owner

eddelbuettel commented Dec 16, 2016

Ok. I'll retitle this ticket and take it as a request to add sort as it seems to be header-only and suitable.

How soon would you need it? What others have done, eg rstan, is to augment in their sources beyond what we have in BH now, and it to point to it in your sources via an extra -I....

By the next release (in a few months) it will be included in BH. Does that work for you?

@eddelbuettel eddelbuettel changed the title from How can I use spread_sort with BH? to Please add Boost sort to BH Dec 16, 2016

@artemklevtsov

This comment has been minimized.

Show comment
Hide comment
@artemklevtsov

artemklevtsov Dec 16, 2016

Sure. For my own use cases I'll use the system wide headers.

artemklevtsov commented Dec 16, 2016

Sure. For my own use cases I'll use the system wide headers.

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Dec 16, 2016

Owner

If you want to ship to CRAN you could use the 'add missing files to packages sources' route.

Owner

eddelbuettel commented Dec 16, 2016

If you want to ship to CRAN you could use the 'add missing files to packages sources' route.

@artemklevtsov

This comment has been minimized.

Show comment
Hide comment
@artemklevtsov

artemklevtsov Dec 16, 2016

Ok. Thank you for the suggestions and quick replies.
My package now is pre alpha. So I'll wait the next BH release without any troubles.

artemklevtsov commented Dec 16, 2016

Ok. Thank you for the suggestions and quick replies.
My package now is pre alpha. So I'll wait the next BH release without any troubles.

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Dec 16, 2016

Owner

All good. If you have a suggestion for where / how I could say more clearly that BH is a subset of Boost, don't hold back ;-)

Owner

eddelbuettel commented Dec 16, 2016

All good. If you have a suggestion for where / how I could say more clearly that BH is a subset of Boost, don't hold back ;-)

eddelbuettel added a commit that referenced this issue Aug 12, 2017

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Aug 12, 2017

Owner

This is now in master awaiting a release "real soon now" (but two other issues need to get sorted out first).

Owner

eddelbuettel commented Aug 12, 2017

This is now in master awaiting a release "real soon now" (but two other issues need to get sorted out first).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment