Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upprovide better defaults for colortheme and two fontsizes #13
Conversation
|
I had put these defaults inside the theme file, and they only got over-ridden in the template if the user had specified something in the yaml. Putting them in the template directly is fine, but then we don't need them also specified in the theme file -- only like to lead to confusion. I'd prefer to include at least |
|
That's what eg the vignette is for: showing all possible values. The YAML header is not where documentation should be. I prefer the skeleton (header) to be minimally viable (ie to work with minimal settings). And it wasn't really -- I had started by deleting these values as a test, and the generated pdf just doesn't look right (just try it in the master branch). Whereas now it does (in the PR branch). |
|
Fair enough re yaml. But we still need to not include default values in two places. |
|
I agree that the 'not in two places' is not ideal, but it hardly hurts. Ie for fontsize we now do (in
where the For titlefontsize we now have
and you had a 24 set. Maybe I overlooked that and it worked -- I changed both at the same time. As for the color theme, the style does indeed set a default, but the wrong one. We could could just remove that line. My preference would be to use |
|
Also, pointing to |
|
One more though: How about adding a Another related concern is: what is going to be your master source for the these, and how do we keep them current? "Manually" may work as they are not that big / do not change that often. Thoughts on this for IQSS, @izahn ? |
|
I'm fine keeping the copy of the IQSS theme in binb in sync by hand. I
guess the alternative is git submodules, but I've not really used them
before.
…On Wed, Oct 10, 2018 at 7:22 AM Dirk Eddelbuettel ***@***.***> wrote:
One more though: How about adding a % Also set in template.tex via a
parameter adjustable from the YAML header comment to the value in the
.sty file?
Another related concern is: what is going to be your master source for the
these, and how do we keep them current? "Manually" may work as they are not
that big / do not change that often. Thoughts on this for IQSS, @izahn
<https://github.com/izahn> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AATm0xHUGrffowxdeUQSuvI66xw5sygnks5ujdiFgaJpZM4XUZqy>
.
--
Ista Zahn
Data Science Specialist
The Institute for Quantitative Social Science at Harvard
http://dss.iq.harvard.edu
|
|
Good idea to add the suggested comments to the sty file. I've actually removed the monash beamer template from my MonashEBSTemplates package, so the binb package is now its master source. That's much easier for me than remembering to make changes twice. I added a comment in the MonashEBSTemplates help files to warn any users. |
|
Cool. I like that too. And obviously it's "your" theme so I should let you pick defaults. Ok to leave it with monashwhite, toc and compress true (in yaml), 14pt font and whatever the title has (22 or 24, I'll streamline and check if I get to it). |
|
I'm ok with those defaults. |
|
Ok -- take a look at the commit 265eca3 I just made: for colortheme and titlefont size, the file Good to merge? If so I will and also update the GH repo |
|
Looks good to me. |
This improves (or so I hope) three different YAML header values:
monashwhiteunless overriddenwhich shortens the YAML header.
I guess
tocandcompresscan/should stay. Defaults for these two are less obvious.Thumbs up or down, @robjhyndman and @izahn ?