New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add iqss header option #14

Merged
merged 1 commit into from Oct 12, 2018

Conversation

Projects
None yet
2 participants
@izahn
Collaborator

izahn commented Oct 12, 2018

This allows the header graphic to be set in the YAML header. It makes the theme usable outside IQSS / Harvard, though the default is still to use the IQSS header graphic.

I'm not really sure I've done this in the best way. In particular, I'd like to have a way of using no header graphic. Suggestions welcome.

@eddelbuettel

This comment has been minimized.

Owner

eddelbuettel commented Oct 12, 2018

This took me a moment to grok. Let me see if I have this right:

  • the sty files define titlegraphic as before, and we copy the existing png as before
  • so existing behaviour is unchanged and we produce identical pdf files
  • but by allowing for optionally set yaml variable you permit an override

Do I have that right? That's slick. Well done.

@izahn

This comment has been minimized.

Collaborator

izahn commented Oct 12, 2018

@eddelbuettel

This comment has been minimized.

Owner

eddelbuettel commented Oct 12, 2018

I can only think of somewhat clumsy ways. Ie we could have different style files definining with/without header and then have template.tex include one or the other.

@eddelbuettel eddelbuettel merged commit a9820a5 into master Oct 12, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment