Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable beamer options via yaml metadata #17

Merged
merged 4 commits into from May 4, 2019

Conversation

Projects
None yet
4 participants
@jolars
Copy link
Contributor

commented May 3, 2019

This small pull request adds the ability to pass options for beamer along through the metadata argument beameroption for the monash, iqss, and metropolis themes. In addition, it adds the pgfpages package to these templates' themes so that some options, such as "show notes on second screen", work without having to manually require the package.

The edits come straight from the official pandoc template for latex:

https://github.com/jgm/pandoc-templates/blob/64a929d7eec7f2c0b741433b30d6b904354a4e74/default.latex#L42-L49

jolars added some commits May 3, 2019

Use pgfpages ctan package in iqss, metropolis and monash templates
* Adding the pgfpages package enables several options from beamer, such as "show notes on second screen"
@eddelbuettel

This comment has been minimized.

Copy link
Owner

commented May 3, 2019

Hi @jolars that looks pretty nice and clean. Two questions, though:

  1. Do you have an example use we could (should) stick into the demos?

  2. How common in pgfpages? Should the latex code test for ir being available? Ie. my Ubuntu machines seem to have it in texlive-pictures, I can imagine some more "narrow" machines not having all of texlive installed. We probably would not want them to break. A quick googleing lead me to https://tex.stackexchange.com/questions/15306/conditional-if-a-package-is-available -- shall we add logic like it?

@jolars

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

  1. I took the liberty to modify the metropolis demo (vignette) by adding a slide using notes. Would something like that work?
  2. You're right. I added the IfFileExists command to check for existence of pgfpages.sty.

@eddelbuettel eddelbuettel self-requested a review May 3, 2019

@eddelbuettel eddelbuettel self-assigned this May 3, 2019

@eddelbuettel

This comment has been minimized.

Copy link
Owner

commented May 3, 2019

@izahn @robjhyndman Any comments or objections? Looks like a nice and clean addition.

@izahn

This comment has been minimized.

Copy link
Collaborator

commented May 3, 2019

Looks good to me 👍

@robjhyndman

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019

Me too. A nice addition.

@eddelbuettel

This comment has been minimized.

Copy link
Owner

commented May 4, 2019

Yes indeed -- nice work and thank @jolars

I'll do some follow-up polish like the missing ChangeLog etc. Probably tomorrow.

@eddelbuettel eddelbuettel merged commit 99621f8 into eddelbuettel:master May 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.