Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Monash template #20

Merged
merged 6 commits into from Aug 21, 2019

Conversation

@robjhyndman
Copy link
Contributor

robjhyndman commented Aug 21, 2019

  • Allowed user-specified title page
  • Fall back to bera font if carlito not available.

As per #12

@eddelbuettel

This comment has been minimized.

Copy link
Owner

eddelbuettel commented Aug 21, 2019

Nice! Do you have a (test or illustration) example for the titlepage mod?

@robjhyndman

This comment has been minimized.

Copy link
Contributor Author

robjhyndman commented Aug 21, 2019

Yes. Where should it go?

@eddelbuettel

This comment has been minimized.

Copy link
Owner

eddelbuettel commented Aug 21, 2019

Maybe inst/monashDemo/userTitleDemo.{Rmd,pdf} ?

@robjhyndman

This comment has been minimized.

Copy link
Contributor Author

robjhyndman commented Aug 21, 2019

Done. I showed off a couple of other options as well.

@eddelbuettel

This comment has been minimized.

Copy link
Owner

eddelbuettel commented Aug 21, 2019

Love it. Will merge and peruse. Thanks much!

@eddelbuettel eddelbuettel merged commit 27f4e05 into eddelbuettel:master Aug 21, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.