New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

presento theme #4

Merged
merged 3 commits into from Sep 24, 2018

Conversation

Projects
None yet
2 participants
@eddelbuettel
Owner

eddelbuettel commented Sep 22, 2018

This is from this repo here and has a nice demo. Some font-sizes are still off though.
The last slide is a winner though :)

@izahn Give it a spin if you can. It is even more demanding on fonts than IQSS is (but I packaged two in repos pkg-font-{montserrat,alegreya-sans} here, and noto, lato and inconsolata are in Ubuntu) so if you can't test it just let me know. This one is interesting as it is a little different from the Beamer cookie-cutter, and I found it high up on this list here.

Then let's think if we want to add it or not. And no further surprises -- I have nothing else in the pipeline right now.

presento theme
from github.com/RatulSaha/presento
see github.com/RatulSaha/presento/blob/master/presento.pdf

some font-size still off

@eddelbuettel eddelbuettel requested a review from izahn Sep 22, 2018

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Sep 23, 2018

Owner

@izahn Did you get a chance to poke around? Any yay/nay/maybe comments?

Owner

eddelbuettel commented Sep 23, 2018

@izahn Did you get a chance to poke around? Any yay/nay/maybe comments?

@izahn

I like the theme a lot, and the demo worked without any problems. I don't think the font requirements are a problem; all but Algreya were available in the Arch Linux User Repository, and in the worst case it only takes a few minutes to download and install them using standard desktop font management on all major desktop platforms. I do think we should add a note to the Requirements section of the README noting the font requirements, as we do for the other themes. Bottom line, a big thumbs up from me.

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Sep 24, 2018

Owner

Thanks for the encouraging feedback. I kinda "fell" for the theme when I first saw it as it looks different. I then started to get a little concerned as the use was very LaTeX-ish and not so markdown-oriented. But with a bit of fidding Fri + Sat I got most of it covered. The bulleted list is still different as ge defines a new list env we cannot get to from Markdown -- but plain LaTeX is an option too for the odd slide. And the 'plain color background' seems a nono just as it is in Metropolis. Unless one does what you did very cleverly and redefines the section headers which I still love.

So cool -- will merge, maybe by tomorrow.

And yes on the 'better docs in README'. I was also wondering if we could run a configure style check for the package to test for fonts. Not sure there is a portable way though...

Owner

eddelbuettel commented Sep 24, 2018

Thanks for the encouraging feedback. I kinda "fell" for the theme when I first saw it as it looks different. I then started to get a little concerned as the use was very LaTeX-ish and not so markdown-oriented. But with a bit of fidding Fri + Sat I got most of it covered. The bulleted list is still different as ge defines a new list env we cannot get to from Markdown -- but plain LaTeX is an option too for the odd slide. And the 'plain color background' seems a nono just as it is in Metropolis. Unless one does what you did very cleverly and redefines the section headers which I still love.

So cool -- will merge, maybe by tomorrow.

And yes on the 'better docs in README'. I was also wondering if we could run a configure style check for the package to test for fonts. Not sure there is a portable way though...

@eddelbuettel eddelbuettel merged commit 67f1334 into master Sep 24, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@eddelbuettel eddelbuettel deleted the feature/presento branch Sep 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment