Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less ambitious testing? #104

Closed
eddelbuettel opened this issue Jul 17, 2020 · 6 comments
Closed

Less ambitious testing? #104

eddelbuettel opened this issue Jul 17, 2020 · 6 comments

Comments

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Jul 17, 2020

@FelixErnst please take a look at https://cloud.r-project.org/web/checks/check_results_drat.html

Should we ... simply skip test on oldrel?

@FelixErnst
Copy link
Contributor

@FelixErnst FelixErnst commented Jul 17, 2020

I am sorry for that. This didn't turned out as I expected... or lets say easy/straight forward.

I installed r-oldrel and tested it now on release and oldrel. I fixed the one error by introduced a conditon during testing.

See #105

@eddelbuettel
Copy link
Owner Author

@eddelbuettel eddelbuettel commented Jul 17, 2020

You're very committed to this. I would have skipped it :)

@FelixErnst
Copy link
Contributor

@FelixErnst FelixErnst commented Jul 17, 2020

In for a penny, in for a pound? Thats a saying isn't it?

@eddelbuettel
Copy link
Owner Author

@eddelbuettel eddelbuettel commented Jul 18, 2020

Fixed by #105 -- thanks!

@FelixErnst
Copy link
Contributor

@FelixErnst FelixErnst commented Jul 20, 2020

Closed?

@eddelbuettel
Copy link
Owner Author

@eddelbuettel eddelbuettel commented Jul 20, 2020

Apparently I meant to but forgot... Trying again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.