Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport windows and macosx binary packages #16
Conversation
|
from #13
The current code is doing it slightly different: it asked what type the package is and constructs the path where to copy the package to accordingly. I could refactor both big switches into two functions which would do |
5d1e963
to
c9b7121
This commit adds support for windows and macosx binary packages.
Package type is automatically inferred from the filename.
It also creates the package structure
(`./{src|bin/windows|bin/macosx}/contrib/{rversion/|}`) if these
dirs do not exist.
Closes: #4
c9b7121
to
3f9810f
|
I've updated the PR by moving the the main logic into (unexported) functions. I added the possibility to supply R version information to this functions, but didn't expose this in the main 'installPackages()` call. The binary support is tested against the R repo for the jupyter R kernel packages, both for 3.1 and 3.2 |
|
Thumbs up for an actual Windows repository. I still have a Windows box at work (maybe not for long) that I should be able to test on. I still don't understand by you don't follow the standard naming scheme of using drat and gh-pages. People already find drat to be confusing, if we add another naming scheme more heads will explode. I do understand your point that it is "yet another" http-serviceable scheme from GH, but it is a) different leading to yet more explanation and) longer to type. But in a way that's "your problem" and the README referenced above makes it clear -- I just shrug. |
|
That said, I do like the new schme with the helper functions. That is much better. |
|
@eddelbuettel you mean why not add to a drat subdir? Mainly because I had to do it manually (script here) and forgot the subdir. And then never used drat to get packages from there, only |
|
So supposed you add
which I find much simpler -- plus having the I'll play with Windows binaries tomorrow. I may have a use case. |
Support windows and macosx binary packages
277b5dc
into
eddelbuettel:master
This commit adds support for windows and macosx binary packages.
Package type is automatically inferred from the filename.
It also creates the package structure
(
./{src|bin/windows|bin/macosx}/contrib/{rversion/|}) if thesedirs do not exist.
Closes: #4