Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to pull remote repo before inserting a package #38

Merged
merged 2 commits into from Sep 10, 2015

Conversation

@markvanderloo
Copy link
Contributor

@markvanderloo markvanderloo commented Sep 9, 2015

Hi Dirk,

I had to re-clone my drat repo several times because I keep forgetting to pull the remote repo before inserting a package. So I thought it would be handy if drat::insertPackage pulls the remote repo before committing.

I added an option pullfirst with default FALSE so all should behave backwards compatible.

Don't merge it if you don't think its useful.

Cheers,
Mark

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Sep 9, 2015

Yes, been there, done that too. Not yet entirely sure if it belongs in drat though -- but possibly. I'll think about but I think I like. Maybe renamed to refreshrepo or pullrepo ...

Do you use a command-line wrapper to call insertPackage()?

@markvanderloo
Copy link
Contributor Author

@markvanderloo markvanderloo commented Sep 9, 2015

yes, I have a small .sh that shebangs /usr/bin/Rscript. see here. It is very crude. I thought of doing it from the script but my dislike to use 'setwd' in a script has stopped me until now :).

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Sep 9, 2015

Similar here -- but I don't call my Rscript scripts .sh :)

eddelbuettel added a commit that referenced this pull request Sep 10, 2015
Added option to pull remote repo before inserting a package
@eddelbuettel eddelbuettel merged commit 80873a3 into eddelbuettel:master Sep 10, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.