Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to secure github repo. #50

Merged
merged 1 commit into from Jun 3, 2016
Merged

Conversation

@csgillespie
Copy link
Contributor

@csgillespie csgillespie commented Jun 2, 2016

The drat repo supports https. Since CRAN is https, makes sense to switch.

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Jun 2, 2016

Don't disagree, but we may need to depend on a minimum version of R in order to ensure consistent https client-side support.

@csgillespie
Copy link
Contributor Author

@csgillespie csgillespie commented Jun 2, 2016

Drat already depends on R (>= 3.2.0). So we should be OK in terms of dependencies.

@eddelbuettel
Copy link
Owner

@eddelbuettel eddelbuettel commented Jun 3, 2016

Also in ChangeLog:

2015-02-02  Dirk Eddelbuettel  <edd@debian.org>

    * R/addRepo.R (addRepo): Use http, not https, at GitHub

    * man/drat-package.Rd: Ditto

So yes, this just completes things. Thanks for the catch!

@eddelbuettel eddelbuettel merged commit 0cb0026 into eddelbuettel:master Jun 3, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@csgillespie csgillespie mentioned this pull request Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.