New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put 3.3 mac binaries in mavericks, 3.4 in el-capitan #67

Merged
merged 4 commits into from Dec 16, 2017

Conversation

Projects
None yet
3 participants
@nfultz
Contributor

nfultz commented Dec 15, 2017

This is a partial solution to #64 - enough to get our travis builds to put mac binaries in the correct folders. There doesn't seem like a good way to tell which folder (mavericks/el-capitan) a mac non-compiled package goes in, so I'm defaulting to the version of R running drat in that case.

Neal and others added some commits Dec 12, 2017

Merge pull request #2 from nfultz/nfultz/el-capitan
Use R's mac osx if available.
@eddelbuettel

Looks good to me but I don't have osX nearby :-/

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Dec 15, 2017

Owner

Hey @coatless any chance you could glance at this and nod? It seems to do the Right Thing (TM).

Owner

eddelbuettel commented Dec 15, 2017

Hey @coatless any chance you could glance at this and nod? It seems to do the Right Thing (TM).

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Dec 16, 2017

Owner

No help from @coatless but I'll merge now.

Owner

eddelbuettel commented Dec 16, 2017

No help from @coatless but I'll merge now.

@eddelbuettel eddelbuettel merged commit 54e749f into eddelbuettel:master Dec 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@coatless

This comment has been minimized.

Show comment
Hide comment
@coatless

coatless Dec 16, 2017

@eddelbuettel sorry been a bit busy. I'll look later in the day.

coatless commented Dec 16, 2017

@eddelbuettel sorry been a bit busy. I'll look later in the day.

@eddelbuettel

This comment has been minimized.

Show comment
Hide comment
@eddelbuettel

eddelbuettel Dec 16, 2017

Owner

In incoming at CRAN aka too late, don't worry.

Owner

eddelbuettel commented Dec 16, 2017

In incoming at CRAN aka too late, don't worry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment