Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPut 3.3 mac binaries in mavericks, 3.4 in el-capitan #67
Conversation
and others
added 4 commits
Dec 12, 2017
Update for el capitan
Use R's mac osx if available.
|
Looks good to me but I don't have osX nearby :-/ |
|
Hey @coatless any chance you could glance at this and nod? It seems to do the Right Thing (TM). |
|
No help from @coatless but I'll merge now. |
eddelbuettel
merged commit 54e749f
into
eddelbuettel:master
1 check passed
1 check passed
|
@eddelbuettel sorry been a bit busy. I'll look later in the day. |
|
In incoming at CRAN aka too late, don't worry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This is a partial solution to #64 - enough to get our travis builds to put mac binaries in the correct folders. There doesn't seem like a good way to tell which folder (mavericks/el-capitan) a mac non-compiled package goes in, so I'm defaulting to the version of R running drat in that case.