Put 3.3 mac binaries in mavericks, 3.4 in el-capitan #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update for el capitan
Use R's mac osx if available.
eddelbuettel
approved these changes
Dec 15, 2017
|
Hey @coatless any chance you could glance at this and nod? It seems to do the Right Thing (TM). |
|
No help from @coatless but I'll merge now. |
|
@eddelbuettel sorry been a bit busy. I'll look later in the day. |
|
In incoming at CRAN aka too late, don't worry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial solution to #64 - enough to get our travis builds to put mac binaries in the correct folders. There doesn't seem like a good way to tell which folder (mavericks/el-capitan) a mac non-compiled package goes in, so I'm defaulting to the version of R running drat in that case.