Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfixed R package repo state, when files are not available any more #95
Conversation
this catches problems, when files are manually deleted, especially newest version files.
| ##' straight file deletion. | ||
| ##' straight file deletion. |
jangorecki
Jun 10, 2020
Contributor
this seems to be unnecessary.
this seems to be unnecessary.
eddelbuettel
Jun 10, 2020
Owner
Please clarify what 'this' is. I can't make sense of your comment.
Please clarify what 'this' is. I can't make sense of your comment.
jangorecki
Jun 10, 2020
Contributor
extra two empty spaces with no purpose
extra two empty spaces with no purpose
eddelbuettel
Jun 10, 2020
Owner
Well -- certain editors do that removal automagically. If it bothers you in diffs, the settings above allows to ignore whitespace and then reload. I sometimes do that because yes -- it is line noise.
Well -- certain editors do that removal automagically. If it bothers you in diffs, the settings above allows to ignore whitespace and then reload. I sometimes do that because yes -- it is line noise.
|
Ok folks, can we please agree that this the last pull request we throw over the fence without prior discussion in an issue ticket? |
|
Sorry for being so straight forward. It caused a bit of problem/confusion on my end after a repo had been active for 6 weeks now and experiencing some heavy changes while a SOP has not clearly been defined, yet. I consider this a bugfix, which was for me warranted an immediate PR. The comment about #65 was included, since it seemed connected, but not confirmed by me. I am of for the next week and a half. |
|
Have a good vacation. We can pick this up when you come back. |
|
I am confused now. I thought we were finalizing this? Oh well |
|
I think it needs more discussion on the issue. I would re-open this, if its clear what the consensus is. |
|
Sorry, this fell to the wayside as the combination of way too much Sturm & Drang followed by a hectic and not exactly coordinayed commit wave followed by you being away was apparently too much to keep up calmly. Looks good now, so I'll merge and likely upload a new version soon, possibly after some light testing here. Thanks for making those changes. I think this is all for the better. |
eddelbuettel
merged commit 2f62e2a
into
eddelbuettel:master
this catches problems, when files are manually deleted, especially files from newest package versions.
adds constency to manages repos and might add to solving #65