Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upbugfix for adding the newest package again, while selecting "archive"… #97
Conversation
… as action zero number of packages are removed in this case and updateRepo throws an error as expected.
|
Nice catch. I still appreciate ChangeLog entries too :) (but I don't mind adding them ex-post so need for a PR just for that) |
eddelbuettel
merged commit b4d5c31
into
eddelbuettel:master
1 check passed
1 check passed
|
will do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
… as action
zero number of packages are removed in this case and updateRepo throws an error as expected.
This escaped my tests and I stumbled upon it by accident. test for this is added as well.